The 'auto' values on align-self and justify-self must not be resolved using the parent's align-items and justify-items computed value. https://lists.w3.org/Archives/Public/www-style/2015Dec/0061.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5389373c6dec30d783eb46b4c8190720f411a8a7 commit 5389373c6dec30d783eb46b4c8190720f411a8a7 Author: jfernandez <jfernandez@igalia.com> Date: Tue May 30 00:56:52 2017 [css-align] Don't resolve 'auto' values for computed style. The CSS Box Alignment specification has been changed recently so that now all the propeties have the specificed value as computed value. The rationale of this change are at the associated W3C github issue [1]. This change implies that we don't need to execute the StyleAdjuter logic we implemented specifically for supporting 'auto' values resolution for computed style. We can live now with resolution at layout time only. [1] https://github.com/w3c/csswg-drafts/issues/440 BUG= 725489 Review-Url: https://codereview.chromium.org/2455093002 Cr-Commit-Position: refs/heads/master@{#475400} [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/css3/flexbox/css-properties-expected.txt [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/css3/flexbox/css-properties.html [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/external/wpt/css/css-align-3/default-alignment/place-items-shorthand-006.html [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes-expected.html [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes.html [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/alignment/ensure-flexbox-compatibility-with-initial-values-expected.txt [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/alignment/new-alignment-values-invalid-if-grid-not-enabled.html [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html [delete] https://crrev.com/9abc1e4d296152077d667de7864bc580eccb0638/third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements-expected.txt [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements.html [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/alignment/parse-place-content.html [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/alignment/parse-place-self.html [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.h [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/layout/LayoutGrid.cpp [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/layout/LayoutGrid.h [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/style/ComputedStyle.cpp [modify] https://crrev.com/5389373c6dec30d783eb46b4c8190720f411a8a7/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e4d09ab6b864897d8399ccda555a61b030ceb84 commit 8e4d09ab6b864897d8399ccda555a61b030ceb84 Author: pfeldman <pfeldman@chromium.org> Date: Tue May 30 23:32:05 2017 Revert of [css-align] Don't resolve 'auto' values for computed style. (patchset #12 id:210001 of https://codereview.chromium.org/2455093002/ ) Reason for revert: This patch breaks DevTools toolbars (Console gear icon, checkbox labels are centered), it also seems to break the Welcome to Chrome page layout. Original issue's description: > [css-align] Don't resolve 'auto' values for computed style. > > The CSS Box Alignment specification has been changed recently so that > now all the propeties have the specificed value as computed value. The > rationale of this change are at the associated W3C github issue [1]. > > This change implies that we don't need to execute the StyleAdjuter > logic we implemented specifically for supporting 'auto' values > resolution for computed style. We can live now with resolution at > layout time only. > > [1] https://github.com/w3c/csswg-drafts/issues/440 > > BUG= 725489 > > Review-Url: https://codereview.chromium.org/2455093002 > Cr-Commit-Position: refs/heads/master@{#475400} > Committed: https://chromium.googlesource.com/chromium/src/+/5389373c6dec30d783eb46b4c8190720f411a8a7 TBR=cbiesinger@chromium.org,cbiesinger@google.com,meade@chromium.org,rego@igalia.com,svillar@igalia.com,jfernandez@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 725489 Review-Url: https://codereview.chromium.org/2913093002 Cr-Commit-Position: refs/heads/master@{#475689} [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/css3/flexbox/css-properties-expected.txt [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/css3/flexbox/css-properties.html [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/external/wpt/css/css-align-3/default-alignment/place-items-shorthand-006.html [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes-expected.html [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes.html [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/ensure-flexbox-compatibility-with-initial-values-expected.txt [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/new-alignment-values-invalid-if-grid-not-enabled.html [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html [add] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements-expected.txt [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements.html [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/parse-place-content.html [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/alignment/parse-place-self.html [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.h [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/layout/LayoutGrid.cpp [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/layout/LayoutGrid.h [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/style/ComputedStyle.cpp [modify] https://crrev.com/8e4d09ab6b864897d8399ccda555a61b030ceb84/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3 commit d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3 Author: jfernandez <jfernandez@igalia.com> Date: Wed May 31 21:12:30 2017 Reland of [css-align] Don't resolve 'auto' values for computed style. Fixed the regression caused by the previous patch and provided a proper regression test. Reason for revert: This patch breaks DevTools toolbars (Console gear icon, checkbox labels are centered), it also seems to break the Welcome to Chrome page layout. Original issue's description: > [css-align] Don't resolve 'auto' values for computed style. > > The CSS Box Alignment specification has been changed recently so that > now all the propeties have the specificed value as computed value. The > rationale of this change are at the associated W3C github issue [1]. > > This change implies that we don't need to execute the StyleAdjuter > logic we implemented specifically for supporting 'auto' values > resolution for computed style. We can live now with resolution at > layout time only. > > [1] https://github.com/w3c/csswg-drafts/issues/440 > > BUG= 725489 > > Review-Url: https://codereview.chromium.org/2455093002 > Cr-Commit-Position: refs/heads/master@{#475400} > Committed: https://chromium.googlesource.com/chromium/src/+/5389373c6dec30d783eb46b4c8190720f411a8a7 TBR=cbiesinger@chromium.org,cbiesinger@google.com,meade@chromium.org,rego@igalia.com,svillar@igalia.com,jfernandez@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 725489 Review-Url: https://codereview.chromium.org/2913093002 Cr-Commit-Position: refs/heads/master@{#475689} Committed: https://chromium.googlesource.com/chromium/src/+/8e4d09ab6b864897d8399ccda555a61b030ceb84 BUG= 725489 Review-Url: https://codereview.chromium.org/2915773002 Cr-Commit-Position: refs/heads/master@{#476024} [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/css3/flexbox/css-properties-expected.txt [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/css3/flexbox/css-properties.html [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/external/wpt/css/css-align-3/default-alignment/place-items-shorthand-006.html [add] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox-1/align-items-006.html [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes-expected.html [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/alignment/alignment-and-anomymous-boxes.html [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/alignment/ensure-flexbox-compatibility-with-initial-values-expected.txt [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/alignment/new-alignment-values-invalid-if-grid-not-enabled.html [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html [delete] https://crrev.com/30333e4db8213d4d2ad82dd1a8774187db35705b/third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements-expected.txt [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/alignment/parse-alignment-of-root-elements.html [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/alignment/parse-place-content.html [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/alignment/parse-place-items.html [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/alignment/parse-place-self.html [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.h [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/layout/LayoutGrid.cpp [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/layout/LayoutGrid.h [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/style/ComputedStyle.cpp [modify] https://crrev.com/d10fc6ad638e7cd58576fd378ee4fcf1481c0ed3/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/441bcf3c591c70fdadf90fcc127f54547d6e3084 commit 441bcf3c591c70fdadf90fcc127f54547d6e3084 Author: Javier Fernandez <jfernandez@igalia.com> Date: Fri Jun 02 13:23:18 2017 [css-align][css-flex] Adapting tests to the new 'auto' value resolution There are some test cases that were incorrectly marked as FAIL in a previous change, so this patch updates the test and its expected results. Bug: 725489 Change-Id: I50240a95aeb9d3bd182c7215e725281482af64c9 Reviewed-on: https://chromium-review.googlesource.com/522565 Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#476626} [modify] https://crrev.com/441bcf3c591c70fdadf90fcc127f54547d6e3084/third_party/WebKit/LayoutTests/css3/flexbox/css-properties-expected.txt [modify] https://crrev.com/441bcf3c591c70fdadf90fcc127f54547d6e3084/third_party/WebKit/LayoutTests/css3/flexbox/css-properties.html
This issue should be FIXED now.
Comment 1 by jfernan...@igalia.com
, May 23 2017