New issue
Advanced search Search tips

Issue 725487 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 416864



Sign in to add a comment

Enable netinfo on Windows

Project Member Reported by jkarlin@chromium.org, May 23 2017

Issue description

Windows now returns wifi/ethernet, so let's enable netinfo.
 
Labels: OS-Windows
Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b0ea35f8c93c6eb229ba09624d566a339b3073b

commit 6b0ea35f8c93c6eb229ba09624d566a339b3073b
Author: jkarlin <jkarlin@chromium.org>
Date: Fri May 26 19:10:42 2017

[NetworkChangeNotifier] Run Windows connection type computation on safe thread

1. Move RecomputeCurrentConnectionType to anonymous namespace
2. Call RecomputeCurrentConnectionType via callback so tests can override
3. Call RecomputeCurrentConnectionType on dns thread
4. Tests inject their own dns task runner

BUG= 721461 ,725487

Review-Url: https://codereview.chromium.org/2893943002
Cr-Commit-Position: refs/heads/master@{#475082}

[modify] https://crrev.com/6b0ea35f8c93c6eb229ba09624d566a339b3073b/net/base/network_change_notifier_win.cc
[modify] https://crrev.com/6b0ea35f8c93c6eb229ba09624d566a339b3073b/net/base/network_change_notifier_win.h
[modify] https://crrev.com/6b0ea35f8c93c6eb229ba09624d566a339b3073b/net/base/network_change_notifier_win_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2017

Labels: merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6da688ab3117d09406f40fd3395c6874d0d39039

commit 6da688ab3117d09406f40fd3395c6874d0d39039
Author: Josh Karlin <jkarlin@chromium.org>
Date: Wed May 31 17:28:50 2017

[NetworkChangeNotifier] Run Windows connection type computation on safe thread

*Merge to M60*

1. Move RecomputeCurrentConnectionType to anonymous namespace
2. Call RecomputeCurrentConnectionType via callback so tests can override
3. Call RecomputeCurrentConnectionType on dns thread
4. Tests inject their own dns task runner

BUG= 721461 ,725487

Review-Url: https://codereview.chromium.org/2893943002
Cr-Commit-Position: refs/heads/master@{#475082}
(cherry picked from commit 6b0ea35f8c93c6eb229ba09624d566a339b3073b)

TBR=pauljensen

Review-Url: https://codereview.chromium.org/2914833002 .
Cr-Commit-Position: refs/branch-heads/3112@{#59}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/6da688ab3117d09406f40fd3395c6874d0d39039/net/base/network_change_notifier_win.cc
[modify] https://crrev.com/6da688ab3117d09406f40fd3395c6874d0d39039/net/base/network_change_notifier_win.h
[modify] https://crrev.com/6da688ab3117d09406f40fd3395c6874d0d39039/net/base/network_change_notifier_win_unittest.cc

Status: Untriaged (was: Started)
Status: Started (was: Untriaged)

Sign in to add a comment