New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725486 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Favicons of back/forward buttons popup menus are default

Reported by mer...@yandex-team.ru, May 23 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.137 YaBrowser/17.4.1.758 Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
1. Ensure that the browser opens recent tabs on restart. (Turn this option in Settings)
2. Open a tab and make some navigation history for it. (Just visit few sites and/or internal pages chrome://blablabla).
3. Close the browser.
4. Start the browser again. The recent tab should appear.
5. Tap-n-hold a back or forward button (depends on what of them is enabled).
6. A popup menu with the history appears.

Expected: favicons of visited sites.
Occured: default favicons (an empty document)

7. Jump to a navigation entry. (With serial clicks on the buttons, or immediate click on the menu item, it does not matter).
8. Jump to the site you have started with, in point 4.
9. Tap-n-hold the button again.
10. The menu appears.

Occured: actual favicons of recently visited sites.

What is the expected behavior?
NavigationEntry of restored session should be set up with cached favicons.

The BackForwardMenuModel should check if a favicon is absent, asynchronously pull it from FaviconService and update corresponding menu item.

What went wrong?
I'm not sure what happens with restored session. Just researched what's wrong with the menu itself.

First, the ToolbarButton (the base class of BackButton, responsible for showing arbitrary menus) does not provide an implementation of MenuModelDelegate. Thus, BackForwardMenuModel abandons any attempts to update favicons: "if (!menu_model_delegate()) return;"
TODO: implement it.

Second, BackForwardMenuModel cancels all pending queries on MenuWillShow(), that is, immediately after the menu has been created and all queries have been posted. This is wrong, it must cancel them on MenuWillClose().

Did this work before? No 

Chrome version: 60.0.3108.0  Channel: dev
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 25.0 r0

This code NEVER worked, I'm sure.
These bugs were made in 2011

For instance, this CR: https://codereview.chromium.org/6708029/patch/10/2008
the MenuModelDelegate has been introduced but not used,
and MenuWillShow() has been updated.
 
Attached are two screenshots.
chrome-bad-history.png - just after restart and restore previous session
chrome-good-history.png - after walking back and forward which has updated favicons.

chrome-good-history.png
17.4 KB View Download
chrome-bad-history.png
23.2 KB View Download
Labels: Needs-Triage-M60
Cc: msrchandra@chromium.org
Labels: -Needs-Triage-M60 M-60 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Latest Stable# 58.0.3029.110 and Latest Dev# 60.0.3107.4 on Windows, Mac and Linux.
This is a Non-Regression issue existing from M30# 30.0.1549.0, so changing the status to Untriaged for the issue to get addressed.
Thank You.

Comment 4 by lgrey@chromium.org, May 26 2017

Status: Available (was: Untriaged)
Project Member

Comment 5 by sheriffbot@chromium.org, May 28 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
*** UI Mass triage ***

adding labels for expert review.

Able to reproduce the issue Canary #72.0.3618.0

Sign in to add a comment