New issue
Advanced search Search tips

Issue 725470 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: ----



Sign in to add a comment

editing/shadow/doubleclick-on-meter-in-shadow-crash.html crashed on trybots

Project Member Reported by cfroussios@chromium.org, May 23 2017

Issue description

webkit_tests failing on chromium.webkit/WebKit Mac10.11 (dbg)

Builders failed on: 
- WebKit Mac10.11 (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29



 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f23b100a894de093b27aa2bef43165d5e8a68c3a

commit f23b100a894de093b27aa2bef43165d5e8a68c3a
Author: cfroussios <cfroussios@chromium.org>
Date: Tue May 23 12:54:55 2017

disabled editing/shadow/doubleclick-on-meter-in-shadow-crash.html

It is failing and culprit is still unknown.

TBRing least ancient author of the test.

BUG=725470
NOTRY=TRUE
TBR=shinyak

Review-Url: https://codereview.chromium.org/2901803002
Cr-Commit-Position: refs/heads/master@{#473870}

[modify] https://crrev.com/f23b100a894de093b27aa2bef43165d5e8a68c3a/third_party/WebKit/LayoutTests/TestExpectations

Attached stdout of webkit tests
dump.txt
8.9 MB View Download
Labels: -Sheriff-Chromium OS-Mac
Owner: shinyak@chromium.org
Status: Assigned (was: Available)
Assigning to author of the test. Please investigate or triage further.
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21b332056cc4435a440329e7975d65288143e283

commit 21b332056cc4435a440329e7975d65288143e283
Author: cfroussios <cfroussios@chromium.org>
Date: Tue May 23 17:04:55 2017

editing/shadow/doubleclick-on-meter-in-shadow-crash.html is crashing

BUG=725470
NOTRY=TRUE
TBR=shinyak

Review-Url: https://codereview.chromium.org/2902753002
Cr-Commit-Position: refs/heads/master@{#473948}

[modify] https://crrev.com/21b332056cc4435a440329e7975d65288143e283/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by kenrb@chromium.org, May 23 2017

Labels: OS-Windows
Also seeing this test failure on Windows: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/19225

It might be worthwhile to disable on all platforms.

Also, here is a candidate CL that might have caused the crash (I haven't verified): https://codereview.chromium.org/2894383003/

Comment 6 by mek@chromium.org, May 23 2017

Labels: OS-Linux
Also failing on Linux, so yes, disabling everywhere (or trying to revert that) probably makes sense.
Project Member

Comment 7 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3edb377a9d355dba0fa56750267c380c1717646b

commit 3edb377a9d355dba0fa56750267c380c1717646b
Author: mek <mek@chromium.org>
Date: Tue May 23 20:20:57 2017

Disable double-click-on-meter-in-shadow-crash.html on all platforms.

BUG=725470
TBR=shinyak@chromium.org

Review-Url: https://codereview.chromium.org/2898263002
Cr-Commit-Position: refs/heads/master@{#474033}

[modify] https://crrev.com/3edb377a9d355dba0fa56750267c380c1717646b/third_party/WebKit/LayoutTests/TestExpectations

Cc: shinyak@chromium.org
Owner: hayato@chromium.org
Since I'm not working on Shadow DOM related stuff now, let me reroute to hayato@

Comment 9 by hayato@chromium.org, May 24 2017

Cc: hayato@chromium.org
Components: Blink>Editing
Owner: yosin@chromium.org
yosin@, could you take a look?

How is it related to editing?

Comment 10 by yosin@chromium.org, May 24 2017

Components: -Blink>Editing Blink>Editing>Selection
Status: Available (was: Assigned)
Summary: editing/shadow/doubleclick-on-meter-in-shadow-crash.html crashed on trybots (was: webkit_tests failing on chromium.webkit/WebKit Mac10.11 (dbg))
#c9, >How is it related to editing?

Double-click to select word then RenderFrameImpl attempt to retrieve selected text for updating text info.


Here is stack trace in trybot:

EphemeralRange.cpp(44)] Check failed: start_position_ <= end_position_ (DIV style="width: 0%;"@offsetInAnchor[0] vs. DIV id="container" style="width:100px; height: 100px"@offsetInAnchor[0])


STDERR: 0   libbase.dylib                       0x000000011c19bbbe base::debug::StackTrace::StackTrace(unsigned long) + 174
STDERR: 1   libbase.dylib                       0x000000011c19bc5d base::debug::StackTrace::StackTrace(unsigned long) + 29
STDERR: 2   libbase.dylib                       0x000000011c199edc base::debug::StackTrace::StackTrace() + 28
STDERR: 3   libbase.dylib                       0x000000011c239eff logging::LogMessage::~LogMessage() + 479
STDERR: 4   libbase.dylib                       0x000000011c237875 logging::LogMessage::~LogMessage() + 21
STDERR: 5   libblink_core.dylib                 0x0000000128adf70b blink::EphemeralRangeTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> >::EphemeralRangeTemplate(blink::PositionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> > const&, blink::PositionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> > const&) + 1227
STDERR: 6   libblink_core.dylib                 0x0000000128adf7b5 blink::EphemeralRangeTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> >::EphemeralRangeTemplate(blink::PositionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> > const&, blink::PositionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> > const&) + 37
STDERR: 7   libblink_core.dylib                 0x0000000128b30e11 blink::VisibleSelectionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> >::ToNormalizedEphemeralRange() const + 577
STDERR: 8   libblink_core.dylib                 0x0000000128ae9b2f blink::ExtractSelectedText(blink::FrameSelection const&, blink::TextIteratorBehavior) + 79
STDERR: 9   libblink_core.dylib                 0x0000000128ae9aa5 blink::FrameSelection::SelectedText(blink::TextIteratorBehavior const&) const + 85
STDERR: 10  libblink_web.dylib                  0x00000001350fb753 blink::WebLocalFrameImpl::SelectionAsText() const + 195
STDERR: 11  libcontent.dylib                    0x00000001134fa37f content::RenderFrameImpl::SyncSelectionIfRequired(bool) + 1679
STDERR: 12  libcontent.dylib                    0x0000000113535a88 content::RenderFrameImpl::DidChangeSelection(bool) + 536
STDERR: 13  Content Shell Framework             0x000000010e8cb9db test_runner::WebFrameTestProxy<content::RenderFrameImpl, content::RenderFrameImpl::CreateParams const&>::DidChangeSelection(bool) + 91
STDERR: 14  libblink_web.dylib                  0x0000000135002e66 blink::EditorClientImpl::RespondToChangedSelection(blink::LocalFrame*, blink::SelectionType) + 102
STDERR: 15  libblink_core.dylib                 0x0000000128ad9618 blink::Editor::RespondToChangedSelection(blink::PositionTemplate<blink::EditingAlgorithm<blink::NodeTraversal> > const&, unsigned int) + 136
STDERR: 16  libblink_core.dylib                 0x0000000128ae6198 blink::FrameSelection::SetSelectionDeprecated(blink::SelectionTemplate<blink::EditingAlgorithm<blink::NodeTraversal> > const&, unsigned int, blink::TextGranularity) + 888
STDERR: 17  libblink_core.dylib                 0x0000000128ae5def blink::FrameSelection::SetSelection(blink::SelectionTemplate<blink::EditingAlgorithm<blink::NodeTraversal> > const&, unsigned int, blink::CursorAlignOnScroll, blink::TextGranularity) + 63
STDERR: 18  libblink_core.dylib                 0x0000000128ae7508 blink::FrameSelection::SetSelection(blink::SelectionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> > const&, unsigned int, blink::CursorAlignOnScroll, blink::TextGranularity) + 424
STDERR: 19  libblink_core.dylib                 0x0000000128b170c6 blink::SelectionController::SetNonDirectionalSelectionIfNeeded(blink::SelectionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> > const&, blink::TextGranularity, blink::SelectionController::EndPointsAdjustmentMode, blink::HandleVisibility) + 1494
STDERR: 20  libblink_core.dylib                 0x0000000128b15e8e blink::SelectionController::UpdateSelectionForMouseDownDispatchingSelectStart(blink::Node*, blink::VisibleSelectionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> > const&, blink::TextGranularity, blink::HandleVisibility) + 334
STDERR: 21  libblink_core.dylib                 0x0000000128b17627 blink::SelectionController::SelectClosestWordFromHitTestResult(blink::HitTestResult const&, blink::SelectionController::AppendTrailingWhitespace, blink::SelectionController::SelectInputEventType) + 1239
STDERR: 22  libblink_core.dylib                 0x0000000128b17bfa blink::SelectionController::SelectClosestWordFromMouseEvent(blink::EventWithHitTestResults<blink::WebMouseEvent> const&) + 442
STDERR: 23  libblink_core.dylib                 0x0000000128b18923 blink::SelectionController::HandleDoubleClick(blink::EventWithHitTestResults<blink::WebMouseEvent> const&) + 435
STDERR: 24  libblink_core.dylib                 0x0000000128b18fa9 blink::SelectionController::HandleMousePressEvent(blink::EventWithHitTestResults<blink::WebMouseEvent> const&) + 553
STDERR: 25  libblink_core.dylib                 0x0000000129229d59 blink::MouseEventManager::HandleMousePressEvent(blink::EventWithHitTestResults<blink::WebMouseEvent> const&) + 1385
STDERR: 26  libblink_core.dylib                 0x0000000129210ace blink::EventHandler::HandleMousePressEvent(blink::WebMouseEvent const&) + 3198
STDERR: 27  libblink_web.dylib                  0x000000013504b273 blink::PageWidgetEventHandler::HandleMouseDown(blink::LocalFrame&, blink::WebMouseEvent const&) + 83
STDERR: 28  libblink_web.dylib                  0x0000000135169b19 blink::WebViewImpl::HandleMouseDown(blink::LocalFrame&, blink::WebMouseEvent const&) + 1209
STDERR: 29  libblink_web.dylib                  0x000000013504adf2 blink::PageWidgetDelegate::HandleInputEvent(blink::PageWidgetEventHandler&, blink::WebCo

Comment 11 by yosin@chromium.org, May 26 2017

Owner: ----
Project Member

Comment 12 by sheriffbot@chromium.org, May 28 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Test-Disabled

Comment 14 by yosin@chromium.org, May 29 2018

Status: Available (was: Untriaged)
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment