Regression:Focus is lost after pressing shift+tab key for first instance to navigate back.
Reported by
vku...@etouch.net,
May 23 2017
|
||||
Issue descriptionChrome Version:60.0.3107.4 (Build official)(cohort:Stable)Revision ffa07b070c2b1dc5dd7c22bc8694f497bee5d538-refs/branch-heads/3107@{#6} (64/32 bit) OS:Windows(7,8,8.1), Linux(14.04 LTS), Mac(10.11.6, 10.12.3) What steps will reproduce the problem? (1)Launch chrome and navigate to chrome://settings/searchEngines (2)Add data under 'other search engines' section, press tab key till focus reaches iron icon (3)Hit 'enter key' > press 'edit' option such that overlay appears, press 'esc' key to close overlay such that focus remains on iron icon. (4)Hit shift+tab key to navigate back and observe. Actual: Focus is lost after pressing shift+tab key for first instance to navigate back.(i.e after step 3 & 4) Expected: Focus should be seen on Add button after pressing shift+tab key to navigate back. This is a regression issue broken in 'M59' and below is the manual regression range: Good Build: 59.0.3048.0 Bad Build: 59.0.3049.0
,
May 25 2017
Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/eeccd7ee07f0c25c2de9b9ab4c176ac0b3441e69..46a6015638109694b15eca22261726647c2599dd?pretty=fuller&n=10000 Suspecting : r 458930 ? from Narrow Bisect @scottchen : Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner. Thank you!
,
May 26 2017
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d30a69cd0eba07bbbff2e8efc9b0ab2e335dae4 commit 6d30a69cd0eba07bbbff2e8efc9b0ab2e335dae4 Author: scottchen <scottchen@chromium.org> Date: Fri Jun 09 23:39:43 2017 MD Settings: fix focus-row-behavior allowing invisible focus on rows. In some scenarios when a row's control is focused, the row remained tabindex="0" (i.e. focusable) so shift-tabbing was moving the focus back to the row which is undesired. This CL makes sure that when the control is focused, shift-tabbing would never go back to the containing row. BUG= 725463 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930683003 Cr-Commit-Position: refs/heads/master@{#478458} [modify] https://crrev.com/6d30a69cd0eba07bbbff2e8efc9b0ab2e335dae4/chrome/browser/resources/settings/focus_row_behavior.js
,
Jun 10 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rbasuvula@chromium.org
, May 23 2017Status: Untriaged (was: Unconfirmed)