Regression: Content of Add and Reset overlays is seen out of dialogue box after resizing the browser
Reported by
sans...@etouch.net,
May 23 2017
|
||||||||
Issue descriptionChrome Version : 60.0.3107.4 (Official Build) ffa07b070c2b1dc5dd7c22bc8694f497bee5d538-refs/branch-heads/3107@{#6} 32/64 bit OS: Windows(7,8,10), Linux(14.04 LTS), Mac(10.11.6, 10.12.3). Pre-condition: Enable bookmark bar from chrome://settings (Show bookmark bar) Steps: 1. Launch Chrome and navigate to chrome://settings/resetProfileSettings?origin=userclick 2. Resize the browser window vertically upward such that 'Help make Chrome better' line of overlay is not visible 3. Now press tab key and observe Actual: Content of 'Reset' overlay ('Help make Chrome better' line) is misplaced i.e it is seen out of dialogue box after resizing the browser Expected: Content of 'Reset' overlay should not be seen out of dialogue box after resizing the browser This is a regression issue broken in ‘M-60’, will soon update the bisect info Good build : 60.0.3086.0 Bad build : 60.0.3088.0 Note: Above issue is seen for most of the overlays in md-settings e.g Add overlay Search engine, cookies, etc
,
May 24 2017
,
May 25 2017
The only better solution (to avoid being chopped off or having content leak out of container like this) is to add a scrollbar on the entire dialog. This does create double scrollbars, but only for the edge case that your viewport height will not fit all the necessary content even if the body of the dialog shrinks to as small as 60px. tbuckley@ does the attached video look like an acceptable solution for the edge case? Or if you have other ideas let me know.
,
May 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a28228813e02d31eb1fb50ec263594e5cad1b80a commit a28228813e02d31eb1fb50ec263594e5cad1b80a Author: scottchen <scottchen@chromium.org> Date: Sat May 27 01:33:02 2017 MD Settings: add overflow scroll to fix very constrained dialog heights. BUG= 725460 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2908583002 Cr-Commit-Position: refs/heads/master@{#475210} [modify] https://crrev.com/a28228813e02d31eb1fb50ec263594e5cad1b80a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
,
May 31 2017
,
May 31 2017
tsergeant@ I messed up - unscrollable scrollbars don't show up on Mac so I didn't see this before I landed it. A separate bug has been filed for that issue, I'll track it there and fix it ASAP. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kkaluri@chromium.org
, May 23 2017Labels: hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)