New issue
Advanced search Search tips

Issue 725449 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

WebView logs a message on each Render crash.

Project Member Reported by gsennton@chromium.org, May 23 2017

Issue description

In https://cs.chromium.org/chromium/src/components/crash/android/java/src/org/chromium/components/crash/browser/CrashDumpManager.java we log a message if we haven't explicitly set a callback for crash dumping - WebView doesn't use this utility, but still calls into CrashDumpManager.tryToUploadMinidump() and thus logs the following message on render crashes:

Log.w(TAG, "Ignoring crash observed before a callback was registered...");

We should remove that message for WebView somehow. Maybe declare an empty callback to run?
 
Status: Available (was: Untriaged)
Labels: Hotlist-GoodFirstBug
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 14

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: paulmiller@chromium.org
Owner: isherman@chromium.org
Status: Assigned (was: Untriaged)
We could also just remove the log. isherman@, would that be okay?

The same message is in ChildProcessCrashObserver.
Owner: jperaza@chromium.org
Josh, you've been working on switching over to Crashpad. Do you think this message has any value at this point?
The switch to Crashpad removes CrashDumpManager and WebView uses AwBrowserTerminator instead of ChildProcessCrashObserver, so this message should stop being logged for WebView (as of a few hours from now, probably).
Status: Fixed (was: Assigned)

Sign in to add a comment