New issue
Advanced search Search tips

Issue 725436 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Columns in Telemetry tracing results html are not sorted by time

Project Member Reported by vovoy@chromium.org, May 23 2017

Issue description

See the attach file results.html, the columns are not sorted by time.

I think the root cause is:
javascript Map.get() doesn't support default value.
> Math.min(0, new Map().get(123, 5))
Nan

https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/value/histogram_parameter_collector.html?rcl=08a6e0ac161db7309d8f9cad0ccd38e0b1fd41e0&l=68

 
results.html
1.1 MB View Download

Comment 1 by vovoy@chromium.org, May 24 2017

Cc: charliea@chromium.org fmea...@chromium.org l...@chromium.org

Comment 2 by l...@chromium.org, May 24 2017

Cc: -l...@chromium.org
Owner: benjhayden@chromium.org
Status: Assigned (was: Available)
Cc: -charliea@chromium.org
Cc: -fmea...@chromium.org -benjhayden@chromium.org
Cc: benjhayden@chromium.org
Owner: vovoy@chromium.org
Thank you, vovoy!
https://codereview.chromium.org/2900273002
Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3af7e47d6bbb461c262da3f23038c207615805d

commit c3af7e47d6bbb461c262da3f23038c207615805d
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu May 25 20:51:57 2017

Roll src/third_party/catapult/ beaa071a9..91cd4274e (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/beaa071a9fbc..91cd4274ef67

$ git log beaa071a9..91cd4274e --date=short --no-merges --format='%ad %ae %s'
2017-05-25 vovoy Fix label sorting in results.html

Created with:
  roll-dep src/third_party/catapult
BUG= 725436 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib5de7d829f3f9dd3c6d47119cb5f10b6f8f7c645
Reviewed-on: https://chromium-review.googlesource.com/516023
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474796}
[modify] https://crrev.com/c3af7e47d6bbb461c262da3f23038c207615805d/DEPS

Comment 7 by vovoy@chromium.org, May 26 2017

Description: Show this description

Comment 8 by vovoy@chromium.org, May 26 2017

Status: Fixed (was: Assigned)

Sign in to add a comment