New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725425 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Adding a site reflects twice in Md-settings/content/cookies for Guest mode.

Project Member Reported by rkalavakuntla@chromium.org, May 23 2017

Issue description

Chrome Version:60.0.3105.0/9578.0.0 dev-channel Kip,Paine,Blaze 
OS:chrome

What steps will reproduce the problem?
(1)Open browser in Guest mode and navigate to chrome://md-settings/content/cookies
(2)Now add a site under Block/Clear on exit/Allow section and Observe(Kindly refer video)

Actual:Site is added twice
Expected:Site should be added only once.

This is a Regression issue as same is working fine in M-55(#55.0.2883.105/8872.76.0) stable channel Paine.

NOTE:
1.Issue is not applicable to Windows,Linux OS
2.Issue is also seen latest stable M-58 and beta M-59.

@stevenjb: Please confirm this issue.
 
Actual.mp4
18.3 MB Download
Expected.mp4
14.8 MB View Download
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711fb3b4e484eb70f5a89bbbbbc9a741d23cb427

commit 711fb3b4e484eb70f5a89bbbbbc9a741d23cb427
Author: stevenjb <stevenjb@chromium.org>
Date: Wed Jun 07 02:56:32 2017

Settings: Cookies: Avoid duplicate 'incognito' exceptions in CrOS Guest mode

BUG= 725425 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2921103002
Cr-Commit-Position: refs/heads/master@{#477531}

[modify] https://crrev.com/711fb3b4e484eb70f5a89bbbbbc9a741d23cb427/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/711fb3b4e484eb70f5a89bbbbbc9a741d23cb427/chrome/browser/ui/webui/settings/site_settings_handler.cc

Components: Privacy
Labels: Merge-Request-60
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 12 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 14 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f21706d7a9f2dc6a40ec493ed89c27dbb2da58e8

commit f21706d7a9f2dc6a40ec493ed89c27dbb2da58e8
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jun 14 00:40:34 2017

Settings: Cookies: Avoid duplicate 'incognito' exceptions in CrOS Guest mode

BUG= 725425 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2921103002
Cr-Original-Commit-Position: refs/heads/master@{#477531}
Review-Url: https://codereview.chromium.org/2933343003 .
Cr-Commit-Position: refs/branch-heads/3112@{#331}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/f21706d7a9f2dc6a40ec493ed89c27dbb2da58e8/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/f21706d7a9f2dc6a40ec493ed89c27dbb2da58e8/chrome/browser/ui/webui/settings/site_settings_handler.cc

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment