New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 725421 link

Starred by 1 user
Status: Fixed
Owner:
█ jbau...@chromium.org
not on Chrome anymore
Closed: May 2017
Cc:
bsep@chromium.org
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Border shadow of 'Uninstall google chrome' box disappears after clicking on Windows taskbar.

Reported by avsha...@etouch.net, May 23 2017 
Chrome Version : 60.0.3107.4 (Official Build) ffa07b070c2b1dc5dd7c22bc8694f497bee5d538-refs/branch-heads/3107@{#6} 32/64 bit
OS : Windows 10

What steps will reproduce the problem?
1. Launch chrome, click on Wrench menu and exit from chrome browser.
2. Navigate to 'Windows Control Panel', right click on 'Google Chrome' and select 'Uninstall' option such that 'Uninstall google chrome' box appears.
3. Now click on 'Windows taskbar' and observe the top left and right border shadows of 'Uninstall google chrome' box. (Please review an attached screen-cast)

Actual : Top left and right border shadows of 'Uninstall google chrome' box disappear after clicking on Windows taskbar.

Expected : Border shadows of 'Uninstall google chrome' box should not disappear.

This is a regression issue broken in ‘M-60’, below is the Manual Regression range and will soon update other info.
Good build : 60.0.3077.0
Bad build : 60.0.3078.0

Note : This issue as only observed on Win-10 OS and it is working fine in Windows(7,8), Linux(14.04 LTS) & Mac(10.11.6, 10.12.3) OS.
Actual_Result.mp4
1.7 MB View Download
Expected_Result.mp4
1.5 MB View Download

Comment 1 by avsha...@etouch.net, May 23 2017

Components: Internals>GPU
Labels: hasbisect
Owner: jbau...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/19d202dbc6bdf73ca32943baf33cacb952b6230c..60e0ebaed452659c1274773c8e1869a379a656fa?pretty=fuller&n=10000

Suspecting : r 466207 from Narrow Bisect 

@jbauman : Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner.

Thank you!

Comment 2 by jbau...@chromium.org, May 23 2017

Cc: bsep@chromium.org
Components: -Blink>Paint
If I make HWNDMessageHandler::OnNCActivate always do SetMsgHandled(TRUE); instead of doing DefWindowProcWithRedrawLock then it seems to work. Maybe we should always do that if !delegate_->HasFrame().

Unfortunately the redraw lock isn't doing anything with DirectComposition enabled.
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a283fb63e50aacdb88401e8d1f4b05f15256b705

commit a283fb63e50aacdb88401e8d1f4b05f15256b705
Author: jbauman <jbauman@chromium.org>
Date: Thu May 25 23:05:27 2017

Don't do DefWindowProc on WM_NCACTIVATE if there's no frame.

WM_NCACTIVATE might draw the border around the edge of the window
which causes artifacts, but if there's no system frame then it shouldn't
need to.

BUG= 725421 

Review-Url: https://codereview.chromium.org/2899053007
Cr-Commit-Position: refs/heads/master@{#474837}

[modify] https://crrev.com/a283fb63e50aacdb88401e8d1f4b05f15256b705/ui/views/win/hwnd_message_handler.cc

Comment 4 by jbau...@chromium.org, May 26 2017

Status: Fixed (was: Assigned)
We should also consider making these windows WS_POPUP, though I suspect that has other side-effects.

Comment 5 by msrchandra@chromium.org, May 30 2017

Labels: TE-Verified-60.0.3112.7 TE-Verified-M60
Tested the issue on Chrome Dev# 60.0.3112.7 on Windows and found the issue to be fixed.
Hence adding TE-Verified Labels.
Thank You.
►

Sign in to add a comment