To simplify the interface of the clear browsing data dialog it should be split into a basic and an advanced tab. http://docs/presentation/d/1NI9SR2DpFKAsAmvB0-Bn1QydWKruwNzzTro_B88EsTo/edit#slide=id.g1b4e5636bf_1_16
To simplify the interface of the clear browsing data dialog it should be split into a basic and an advanced tab. Slides: http://docs/presentation/d/1NI9SR2DpFKAsAmvB0-Bn1QydWKruwNzzTro_B88EsTo/edit#slide=id.g1b4e5636bf_1_16 Mocks: https://folio.googleplex.com/clear-browsing-data/Dialog%20-%20V2/Specs#%2FSpec%20-%20Deskop.png%3Fz=width (for native ui and not material design settings, so some changes will be made when implementing it)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8148de4fd6ee28b93a6d2bd40bac79188cf590da commit 8148de4fd6ee28b93a6d2bd40bac79188cf590da Author: dullweber <dullweber@chromium.org> Date: Mon Jun 12 10:18:07 2017 Properly construct 'less than X MB' sentences for CBD Currently "less than X MB" and "less than 1 MB" are inserted into "Frees up $1" this might not work correctly when being translated so this CL adds three separate sentences with only a placeholder for "X MB". BUG= 725401 Review-Url: https://codereview.chromium.org/2935443003 Cr-Commit-Position: refs/heads/master@{#478581} [modify] https://crrev.com/8148de4fd6ee28b93a6d2bd40bac79188cf590da/chrome/browser/browsing_data/browsing_data_counter_utils.cc [modify] https://crrev.com/8148de4fd6ee28b93a6d2bd40bac79188cf590da/chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc [modify] https://crrev.com/8148de4fd6ee28b93a6d2bd40bac79188cf590da/components/browsing_data_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71902b7b2e299e5577fd917d84d83e3900e66fe2 commit 71902b7b2e299e5577fd917d84d83e3900e66fe2 Author: Christian Dullweber <dullweber@chromium.org> Date: Wed Jul 26 13:10:46 2017 Use BrowsingDataType instead of preference names for CBD Use the BrowsingDataType enum instead of preference names to identify the data types that should be deleted by Clear Browsing Data on desktop. Pass the deleted datatypes and timerange from Javascript directly to the handler instead of reading each preference state. This makes desktop more similar to Android and will simplify the introduction of different tabs in CBD. The logic that handles which checkboxes are currently relevant is moved to the UI and the handler doesn't need to differentiate between different UI states. Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id5abb6f2a3ddefdd5e144dcacf8f402bbfe2febd Reviewed-on: https://chromium-review.googlesource.com/574022 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#489624} [modify] https://crrev.com/71902b7b2e299e5577fd917d84d83e3900e66fe2/chrome/browser/android/browsing_data/browsing_data_bridge.cc [modify] https://crrev.com/71902b7b2e299e5577fd917d84d83e3900e66fe2/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js [modify] https://crrev.com/71902b7b2e299e5577fd917d84d83e3900e66fe2/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [modify] https://crrev.com/71902b7b2e299e5577fd917d84d83e3900e66fe2/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js [modify] https://crrev.com/71902b7b2e299e5577fd917d84d83e3900e66fe2/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc [modify] https://crrev.com/71902b7b2e299e5577fd917d84d83e3900e66fe2/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h [modify] https://crrev.com/71902b7b2e299e5577fd917d84d83e3900e66fe2/chrome/test/data/webui/settings/privacy_page_test.js [modify] https://crrev.com/71902b7b2e299e5577fd917d84d83e3900e66fe2/components/browsing_data/core/browsing_data_utils.cc [modify] https://crrev.com/71902b7b2e299e5577fd917d84d83e3900e66fe2/components/browsing_data/core/browsing_data_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c07598be0299431d37794a3d34b9e2cd0dc5866 commit 7c07598be0299431d37794a3d34b9e2cd0dc5866 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Aug 07 12:22:33 2017 Create CBD dialog fork Create a copy of the Clear Browsing Data dialog in order to develop the new UI behind a flag. Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2180d15bb3522b4e03c736a34a0c899a10e1d848 Reviewed-on: https://chromium-review.googlesource.com/597852 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#492303} [add] https://crrev.com/7c07598be0299431d37794a3d34b9e2cd0dc5866/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html [add] https://crrev.com/7c07598be0299431d37794a3d34b9e2cd0dc5866/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.js [modify] https://crrev.com/7c07598be0299431d37794a3d34b9e2cd0dc5866/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/7c07598be0299431d37794a3d34b9e2cd0dc5866/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/7c07598be0299431d37794a3d34b9e2cd0dc5866/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/7c07598be0299431d37794a3d34b9e2cd0dc5866/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9858e2d4c2c962724405b59db33e829a574796d1 commit 9858e2d4c2c962724405b59db33e829a574796d1 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Aug 07 18:21:02 2017 Add note to CBD html and js files Add a note to clear_browsing_data_dialog_tabs.* and clear_browsing_data_dialog.* to indicate that these files are currently forked. TBR=dschuyler@chromium.org Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8f9ca738bad7527c363d845511d4ae37dea062ab Reviewed-on: https://chromium-review.googlesource.com/603713 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#492364} [modify] https://crrev.com/9858e2d4c2c962724405b59db33e829a574796d1/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [modify] https://crrev.com/9858e2d4c2c962724405b59db33e829a574796d1/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js [modify] https://crrev.com/9858e2d4c2c962724405b59db33e829a574796d1/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html [modify] https://crrev.com/9858e2d4c2c962724405b59db33e829a574796d1/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad06b3ed51b7f5a6980e77e8257250c182221cf7 commit ad06b3ed51b7f5a6980e77e8257250c182221cf7 Author: Christian Dullweber <dullweber@chromium.org> Date: Fri Aug 25 09:57:24 2017 Use BrowsingDataType instead of preference names in BrowsingDataApi The new UI for Clear Browsing Data uses different preferences based on whether the deletion happens from the Basic or Advanced tab. This change updates the browsing_data api to use the right preference depending on the selected tab. Bug: 725401 Change-Id: I5b5e692f5568433f068ea015e246883eeaf05846 Reviewed-on: https://chromium-review.googlesource.com/574233 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#497368} [modify] https://crrev.com/ad06b3ed51b7f5a6980e77e8257250c182221cf7/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc [modify] https://crrev.com/ad06b3ed51b7f5a6980e77e8257250c182221cf7/chrome/browser/extensions/api/browsing_data/browsing_data_api.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c871e6fd522ea289b0409dece4e626037fc526ce commit c871e6fd522ea289b0409dece4e626037fc526ce Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Aug 28 09:17:18 2017 Add html sublabel to settings_checkbox This CL adds a way to define html content for the sublabel of a settings-checkbox. This will allow to display a link inside this sublabel. It also adds some margins and changes the display mode to "flex" to fix display issues for labels that span more than one line. Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8f02f65f2fdf78cbcae07a5d8621519dc0b297dd Reviewed-on: https://chromium-review.googlesource.com/605549 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#497723} [modify] https://crrev.com/c871e6fd522ea289b0409dece4e626037fc526ce/chrome/browser/resources/settings/controls/settings_checkbox.html [modify] https://crrev.com/c871e6fd522ea289b0409dece4e626037fc526ce/chrome/browser/resources/settings/controls/settings_checkbox.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6422cdb59a993ce5a2ce0c17b9cfd0fbbad33649 commit 6422cdb59a993ce5a2ce0c17b9cfd0fbbad33649 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Aug 28 11:11:04 2017 Add a way to show tabs in cr_dialog This CL adds a possiblity to insert a tab bar into cr_dialog between title and body. It adds a new "header" slot to cr_dialog and adds mixins to configure the dialog. Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibd8f49599997252182d944bf322f35aafa6b6a5a Reviewed-on: https://chromium-review.googlesource.com/605550 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#497733} [modify] https://crrev.com/6422cdb59a993ce5a2ce0c17b9cfd0fbbad33649/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc736c1176840beadb0ff4ba842fe1a979bba71c commit cc736c1176840beadb0ff4ba842fe1a979bba71c Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Sep 04 09:27:50 2017 Delete and count zoom levels in CBD Add support to delete and count ZoomLevels in order to integrate them with Site Settings deletion for Clear Browsing Data. In order to delete ZoomLevels by time period, I'm storing a timestamp for each zoomlevel to indicate when it was last edited. The timestamp is only stored if the flag TabsInCBD is activated to prevent recording it before the new UI for CBD is ready. Bug: 725401 , 137412 Change-Id: I39ad649cf9bc8ab67e998e7a14c85cf7b153dc70 Reviewed-on: https://chromium-review.googlesource.com/623752 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#499464} [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/chrome/browser/browsing_data/browsing_data_counter_factory.cc [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/chrome/browser/browsing_data/site_settings_counter_unittest.cc [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/components/browsing_data/content/BUILD.gn [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/components/browsing_data/content/DEPS [rename] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/components/browsing_data/content/counters/site_settings_counter.cc [rename] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/components/browsing_data/content/counters/site_settings_counter.h [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/components/browsing_data/core/BUILD.gn [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/components/browsing_data/core/DEPS [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/components/content_settings/core/common/content_settings_pattern.cc [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/components/content_settings/core/common/content_settings_pattern.h [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/content/browser/host_zoom_map_impl.cc [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/content/browser/host_zoom_map_impl.h [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/content/browser/host_zoom_map_impl_unittest.cc [modify] https://crrev.com/cc736c1176840beadb0ff4ba842fe1a979bba71c/content/public/browser/host_zoom_map.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0d96f0f85b736c4310662b7cd88be2546d3a6b6 commit d0d96f0f85b736c4310662b7cd88be2546d3a6b6 Author: Christian Dullweber <dullweber@chromium.org> Date: Wed Sep 13 09:22:51 2017 Split the CBD dialog into a basic and advanced tab To simplify the Clear Browsing Data ui on desktop, we introduce a basic section with the most frequently used options and an advanced section showing the existing options as well as an additional "Site settings" checkbox. The footers are removed and their information is integrated into the checkbox descriptions in the basic tab. This change requires a few additions to cr_dialog to inject a tab bar and restrict the dialog to a fixed height. SettingsCheckbox requires an additional attribute to add html with links to the summary. https://screenshot.googleplex.com/TvDGxE77XUC.png https://screenshot.googleplex.com/CvF0kx7UwSY.png Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic2a84d468d9e4fd74c225d8a3668d8d1663f8da6 Reviewed-on: https://chromium-review.googlesource.com/580987 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#501574} [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/app/settings_strings.grdp [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/about_flags.cc [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/flag_descriptions.h [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.js [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/resources/settings/settings_vars_css.html [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/common/url_constants.cc [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/chrome/common/url_constants.h [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/components/browsing_data/core/browsing_data_utils.h [modify] https://crrev.com/d0d96f0f85b736c4310662b7cd88be2546d3a6b6/components/browsing_data/core/pref_names.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8336a8510772a57d36fd2f66dbc9c8960ef984c commit d8336a8510772a57d36fd2f66dbc9c8960ef984c Author: Christian Dullweber <dullweber@chromium.org> Date: Wed Sep 20 11:33:58 2017 Add border below tabs and increase checkbox margin in CBD Add a border below the tab bar in the Clear Browsing Data dialog and increase space between settings-checkboxes to match mocks. https://screenshot.googleplex.com/r2SK8Xoyo2N.png Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibb80eca981a30995b69e34d2a2009988a202f979 Reviewed-on: https://chromium-review.googlesource.com/668437 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#503111} [modify] https://crrev.com/d8336a8510772a57d36fd2f66dbc9c8960ef984c/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html [modify] https://crrev.com/d8336a8510772a57d36fd2f66dbc9c8960ef984c/chrome/browser/resources/settings/controls/settings_checkbox.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db054f2e008d4bbb983d5f13ad983acba43df555 commit db054f2e008d4bbb983d5f13ad983acba43df555 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Sep 25 09:56:09 2017 Margin, color and text tweaks for CBD This CL changes the button label from "Clear browsing data" to "Clear data", the tab text color to blue and a different grey and makes some improvements to the margins around "Time range". Before: https://screenshot.googleplex.com/HOySYiU6gtx.png After: https://screenshot.googleplex.com/6Jk2Y1jok5C.png Bug: 725401 , 732761 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6f52f248513d3cfaeecc807d1d6a17b7863cb4bc Reviewed-on: https://chromium-review.googlesource.com/678508 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504015} [modify] https://crrev.com/db054f2e008d4bbb983d5f13ad983acba43df555/chrome/app/settings_strings.grdp [modify] https://crrev.com/db054f2e008d4bbb983d5f13ad983acba43df555/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html [modify] https://crrev.com/db054f2e008d4bbb983d5f13ad983acba43df555/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f4989b52fa9fb3bbcf406e7d1b610b36f7c1923 commit 2f4989b52fa9fb3bbcf406e7d1b610b36f7c1923 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Sep 25 15:15:10 2017 Improve browsing_data_api test Change browsing_data_api test to cover changes from the new basic/advanced tab Clear Browsing Data ui. Bug: 725401 Change-Id: Ib58612e2f7d241412007202276936a2c7dc4e77a Reviewed-on: https://chromium-review.googlesource.com/681816 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#504055} [modify] https://crrev.com/2f4989b52fa9fb3bbcf406e7d1b610b36f7c1923/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41cab4fdf74e694376012b622c61a4e8e04fae89 commit 41cab4fdf74e694376012b622c61a4e8e04fae89 Author: Christian Dullweber <dullweber@chromium.org> Date: Tue Sep 26 13:28:22 2017 Enable the new CBD dialog on desktop This enables the new Clear Browsing Data dialog by default for desktop. privacy_page_test.js needs a small fix, so it doesn't break. I will change privacy_page_test.js to completely run on the new ui in https://crrev.com/c/647713. Bug: 725401 Change-Id: I8647e53bc93725c84cf45ada46123d84038c9a78 Reviewed-on: https://chromium-review.googlesource.com/647712 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#504351} [modify] https://crrev.com/41cab4fdf74e694376012b622c61a4e8e04fae89/chrome/common/chrome_features.cc [modify] https://crrev.com/41cab4fdf74e694376012b622c61a4e8e04fae89/chrome/test/data/webui/settings/privacy_page_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9e945d7a77ad84595601ce20828150ae403fd35 commit a9e945d7a77ad84595601ce20828150ae403fd35 Author: Christian Dullweber <dullweber@chromium.org> Date: Tue Sep 26 16:29:45 2017 Choose clear site settings label based on switch The title of the site settings / content settings section depends on the value of switches::kEnableSiteSettings, so the option in Clear Browsing Data should use the same logic to decide which title to show. Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0cdd9642759f9cc321ec9a591445a4c17606c2ef Reviewed-on: https://chromium-review.googlesource.com/681215 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504390} [modify] https://crrev.com/a9e945d7a77ad84595601ce20828150ae403fd35/chrome/app/settings_strings.grdp [modify] https://crrev.com/a9e945d7a77ad84595601ce20828150ae403fd35/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html [modify] https://crrev.com/a9e945d7a77ad84595601ce20828150ae403fd35/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.js [modify] https://crrev.com/a9e945d7a77ad84595601ce20828150ae403fd35/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dde1bbd6646f8e4fd9f29b1aa1ff319f6ce0db2 commit 6dde1bbd6646f8e4fd9f29b1aa1ff319f6ce0db2 Author: Christian Dullweber <dullweber@chromium.org> Date: Wed Sep 27 10:53:38 2017 Use ClearBrowsingDataTabs dialog in privacy page test Run privacy_page tests with the new UI. Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6f47573de3548a729712470f3b7b2f73287d480c Reviewed-on: https://chromium-review.googlesource.com/647713 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#504623} [modify] https://crrev.com/6dde1bbd6646f8e4fd9f29b1aa1ff319f6ce0db2/chrome/test/data/webui/settings/privacy_page_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec97d1e0b35036585d831462d9ce6b7fb1d15e2f commit ec97d1e0b35036585d831462d9ce6b7fb1d15e2f Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Oct 05 10:29:56 2017 Add additional metrics for CBD Record user actions in Clear Browsing Data to keep track of time period changes, switching tabs and deleting from specific tabs. Bug: 725401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1973216047177dfd8a677ccf80b0e8352ba2ecc3 Reviewed-on: https://chromium-review.googlesource.com/678955 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#506694} [modify] https://crrev.com/ec97d1e0b35036585d831462d9ce6b7fb1d15e2f/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html [modify] https://crrev.com/ec97d1e0b35036585d831462d9ce6b7fb1d15e2f/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.js [modify] https://crrev.com/ec97d1e0b35036585d831462d9ce6b7fb1d15e2f/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc [modify] https://crrev.com/ec97d1e0b35036585d831462d9ce6b7fb1d15e2f/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0352cc105cf1fe56a4b0804cdfe978ae61dedac9 commit 0352cc105cf1fe56a4b0804cdfe978ae61dedac9 Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Oct 26 10:24:12 2017 Change history.google.com to myactivity.google.com Change the history url to myactivity in the history notice of CBD and on the history page on Desktop. Add utm_source parameter to myactivity url in history page of Android. Bug: 725401 Change-Id: I32eafc4e13603113fc13c1fb342db7aeb7c1a674 Reviewed-on: https://chromium-review.googlesource.com/738196 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#511782} [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasic.java [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/app/generated_resources.grd [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/app/resources/locale_settings.grd [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/browser/ui/webui/md_history_ui.cc [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/common/url_constants.cc [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/chrome/common/url_constants.h [modify] https://crrev.com/0352cc105cf1fe56a4b0804cdfe978ae61dedac9/components/history_strings.grdp
Comment 1 by dullweber@chromium.org
, May 24 2017