New issue
Advanced search Search tips

Issue 725398 link

Starred by 1 user
Status: Fixed
Owner:
shinyak@chromium.org
Closed: May 2017
Cc:
ukai@chromium.org
tikuta@chromium.org
yyanagisawa@chromium.org
shinyak@chromium.org
sque@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use relative path for -isysroot on Mac

Project Member Reported by shinyak@chromium.org, May 23 2017 
I found -isysroot uses absolute path. If we can use relative path here, goma cache hit rate will improve.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73a56e560b589488448fecd35ead3444cbffdcd6

commit 73a56e560b589488448fecd35ead3444cbffdcd6
Author: shinyak <shinyak@chromium.org>
Date: Wed May 24 01:54:26 2017

Rebase mac sdk path

Using absolute path here causes goma cache miss. Using relative path
will improve goma performance.

BUG= 725398 

Change-Id: Iefac35832a3e20518154999b0989602610dc2020
Reviewed-on: https://chromium-review.googlesource.com/512243
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Shinya Kawanaka <shinyak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474127}
[modify] https://crrev.com/73a56e560b589488448fecd35ead3444cbffdcd6/build/config/mac/BUILD.gn

Comment 2 by shinyak@chromium.org, May 24 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment