New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725386 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 23 2017

Issue description

"benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 27 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygAELEgVGbGFrZSJ1YmVuY2htYXJrcy5zeXN0ZW1faGVhbHRoX3Ntb2tlX3Rlc3QuU3lzdGVtSGVhbHRoQmVuY2htYXJrU21va2VUZXN0LnN5c3RlbV9oZWFsdGgubWVtb3J5X2Rlc2t0b3AuYnJvd3NlOnNvY2lhbDp0d2l0dGVyDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 722233 .
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dbc9a7e8c5ca7a9ac4ae0ab68a6f85ca6887192

commit 5dbc9a7e8c5ca7a9ac4ae0ab68a6f85ca6887192
Author: cfroussios <cfroussios@chromium.org>
Date: Tue May 23 15:42:56 2017

Disable benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter

It is flaky. See bug

TBRing a contributor to the test file.

BUG=725386
TBR=nednguyen

Review-Url: https://codereview.chromium.org/2896293002
Cr-Commit-Position: refs/heads/master@{#473910}

[modify] https://crrev.com/5dbc9a7e8c5ca7a9ac4ae0ab68a6f85ca6887192/tools/perf/benchmarks/system_health_smoke_test.py

Cc: perezju@chromium.org
Labels: -Sheriff-Chromium
Owner: nednguyen@chromium.org
Status: Assigned (was: Untriaged)
Assigning to authors of the test. Please investigate or triage further.
Owner: nedngu...@google.com
 [14014:14014:0519/071445.952582:INFO:CONSOLE(0)] "XMLHttpRequest cannot load https://video.twimg.com/ext_tw_video/754743312280608768/pu/pl/640x360/avWQyuRXESaVJGQA.m3u8. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://twitter.com' is therefore not allowed access. The response had HTTP status code 404.", source: https://twitter.com/i/videos/tweet/754745879345717248?embed_source=clientlib&player_id=0&rpc_init=1&conviva_environment=test (0)

(https://chromium-swarm.appspot.com/task?id=3639ddb614b71310&refresh=10&show_raw=1)

I think this is the issue with twitter page fetch certificate from live network.
Cc: xunji...@chromium.org
Cc: rsleevi@chromium.org
I am not sure if the lack of Access-Control-Allow-Origin header is due to certificate errors seen in the log.
+rsleevi@: Ryan do you know?
I don't see how it would be related. ACAO is something that the origin server would send, and even on coalesced connections (e.g. H/2) is necessary, so it's not likely something related to the test.
Thanks, Ryan.
Ned, maybe this is a flake because WPR doesn't always record the ACAO header sent by the origin server? assuming the test depends on that particular XMLHttpRequest.
Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, Jun 29 2017

Labels: Sheriff-Chromium
Detected 5 new flakes for test/step "benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygAELEgVGbGFrZSJ1YmVuY2htYXJrcy5zeXN0ZW1faGVhbHRoX3Ntb2tlX3Rlc3QuU3lzdGVtSGVhbHRoQmVuY2htYXJrU21va2VUZXN0LnN5c3RlbV9oZWFsdGgubWVtb3J5X2Rlc2t0b3AuYnJvd3NlOnNvY2lhbDp0d2l0dGVyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
oops used the wrong bug number to land this change:
https://chromium.googlesource.com/chromium/src/+/837b9e2e60fce4b0b5043aa9f9c0af766ace8570

Reviewers: nednguyen
CL: https://codereview.chromium.org/2962123002/

Description:
Disabled flaky system health smoke test.

See bug for more details.

TBR=nednguyen@google.com
BUG= 752386 

Affected files (+2, -0 lines):
M tools/perf/benchmarks/system_health_smoke_test.py
Labels: -Sheriff-Chromium
Removing from sheriff queue since the test has been disabled. nednguyen@, ptal when you get a chance.
Owner: nednguyen@chromium.org

Sign in to add a comment