New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725367 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 724708



Sign in to add a comment

EasyUnlock v2: Use cros_system_api constant for SetLEConnectionParameters call in chromium

Project Member Reported by tengs@chromium.org, May 23 2017

Issue description

Due to dependency issues, we need to do this in a future CL.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/d1586d3fcb3ac7152129de96cbe358221ccdca09

commit d1586d3fcb3ac7152129de96cbe358221ccdca09
Author: Tim Song <tengs@chromium.org>
Date: Thu Jun 01 04:14:38 2017

cros_system_api: Add constants for valid parameters of the SetLEConnectionParameters API.

BUG= chromium:725367 
TEST=N/A

Change-Id: Ic50b8c1cf4ab049ac6b058273dbc3a892d77771f
Reviewed-on: https://chromium-review.googlesource.com/516551
Commit-Ready: Tim Song <tengs@chromium.org>
Tested-by: Tim Song <tengs@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>

[modify] https://crrev.com/d1586d3fcb3ac7152129de96cbe358221ccdca09/dbus/service_constants.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/d1586d3fcb3ac7152129de96cbe358221ccdca09

commit d1586d3fcb3ac7152129de96cbe358221ccdca09
Author: Tim Song <tengs@chromium.org>
Date: Thu Jun 01 04:14:38 2017

cros_system_api: Add constants for valid parameters of the SetLEConnectionParameters API.

BUG= chromium:725367 
TEST=N/A

Change-Id: Ic50b8c1cf4ab049ac6b058273dbc3a892d77771f
Reviewed-on: https://chromium-review.googlesource.com/516551
Commit-Ready: Tim Song <tengs@chromium.org>
Tested-by: Tim Song <tengs@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>

[modify] https://crrev.com/d1586d3fcb3ac7152129de96cbe358221ccdca09/dbus/service_constants.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9c939597cd5b8b2af091441674b526cd1cee52e

commit d9c939597cd5b8b2af091441674b526cd1cee52e
Author: tengs <tengs@chromium.org>
Date: Fri Jun 02 01:52:55 2017

Roll src/third_party/cros_system_api/ ff270ca21..d1586d3fc (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/ff270ca217a8..d1586d3fcb3a

$ git log ff270ca21..d1586d3fc --date=short --no-merges --format='%ad %ae %s'
2017-05-25 tengs cros_system_api: Add constants for valid parameters of the SetLEConnectionParameters API.

Created with:
  roll-dep src/third_party/cros_system_api

BUG= 725367 

Review-Url: https://codereview.chromium.org/2920863002
Cr-Commit-Position: refs/heads/master@{#476519}

[modify] https://crrev.com/d9c939597cd5b8b2af091441674b526cd1cee52e/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc37ca3a3cf227adad7cb6c24cf405c24e87d61

commit ebc37ca3a3cf227adad7cb6c24cf405c24e87d61
Author: tengs <tengs@chromium.org>
Date: Fri Jul 14 01:10:03 2017

Replace dbus::BluetoothDeviceClient names with constants from cros_system_api.

Constants added in
https://chromium-review.googlesource.com/c/516551/

BUG= 725367 

Review-Url: https://codereview.chromium.org/2947083002
Cr-Commit-Position: refs/heads/master@{#486580}

[modify] https://crrev.com/ebc37ca3a3cf227adad7cb6c24cf405c24e87d61/device/bluetooth/dbus/bluetooth_device_client.cc

Comment 5 by tengs@chromium.org, Jul 14 2017

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment