Border/padding is added to each line when applied to inline container |
|||
Issue descriptionI guess this is from https://codereview.chromium.org/2886453005. We seem to add border_and_padding to iter_offset and to baseline, we should probably eliminate one of the two, but not sure which. glebl@, can you help?
,
May 29 2017
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfb708ff0dc28bafad16a2833b16823e7efb09f1 commit bfb708ff0dc28bafad16a2833b16823e7efb09f1 Author: kojii <kojii@chromium.org> Date: Wed May 31 05:17:07 2017 [LayoutNG] Fix not to add borders/paddings to every line The initial CL to support borders/paddings of the containing block of inlines[1] added the block start of borders/paddings to every line. This patch fixes to add it only once, to the content_size_, the same way as NGBlockLayoutAlgorithm does. [1] https://codereview.chromium.org/2886453005 BUG=636993, 725359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2914523002 Cr-Commit-Position: refs/heads/master@{#475810} [modify] https://crrev.com/bfb708ff0dc28bafad16a2833b16823e7efb09f1/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/bfb708ff0dc28bafad16a2833b16823e7efb09f1/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc
,
Jun 3 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kojii@chromium.org
, May 29 2017