Chrome Version: c90c34417bb295752d1e7fa96ba5d41c106917fd OS: Android The incremental install does not use the correct checks for Android O, but still uses a codename. It's in org.chromium.incrementalinstall.ClassLoaderPatcher, in the methods makeNativePathElements(...) and addDexElements(...). See these two places: - https://chromium.googlesource.com/chromium/src/+/c90c34417bb295752d1e7fa96ba5d41c106917fd/build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java#224 - https://chromium.googlesource.com/chromium/src/+/c90c34417bb295752d1e7fa96ba5d41c106917fd/build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java#256 For now, since this is in //build, and we don't have the latest SDK available, I suggest copy-pasting the implementation from BuildInfo#isAtLeastO() in base: Build.VERSION.SDK_INT >= 26 See: https://chromium.googlesource.com/chromium/src/+/c90c34417bb295752d1e7fa96ba5d41c106917fd/base/android/java/src/org/chromium/base/BuildInfo.java#171
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1e3cc4ceca89a8c49ee84a2271b24f21b99074e commit d1e3cc4ceca89a8c49ee84a2271b24f21b99074e Author: zpeng <zpeng@chromium.org> Date: Mon Jun 05 19:07:49 2017 Fix incremental build for Android O BUG= 725356 Review-Url: https://codereview.chromium.org/2921313002 Cr-Commit-Position: refs/heads/master@{#477049} [modify] https://crrev.com/d1e3cc4ceca89a8c49ee84a2271b24f21b99074e/build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java
Issue 729541 has been merged into this issue.
Comment 1 by torne@chromium.org
, May 23 2017