New issue
Advanced search Search tips

Issue 725354 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"MediaGalleriesPlatformAppBrowserTest.MediaGalleriesRead" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 23 2017

Issue description

"MediaGalleriesPlatformAppBrowserTest.MediaGalleriesRead" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQgsSBUZsYWtlIjdNZWRpYUdhbGxlcmllc1BsYXRmb3JtQXBwQnJvd3NlclRlc3QuTWVkaWFHYWxsZXJpZXNSZWFkDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by mek@chromium.org, May 23 2017

Cc: reillyg@chromium.org
Components: Platform>Extensions>API
Labels: -Sheriff-Chromium
Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2017

The media galleries code hasn't changed much other than refactorings.

Logs say:

[3504:2756:0522/083750.376:INFO:media_foundation_video_encode_accelerator_win.cc(330)] Windows versions earlier than 8 are not supported.
e:\b\c\b\win\src\base\test\test_reg_util_win.cc(106): error:       Expected: 0L
      Which is: 0
To be equal to: temp_key.Create((( HKEY ) (ULONG_PTR)((LONG)0x80000001) ), key_path.c_str(), (((0x001F0000L) | (0x0001) | (0x0002) | (0x0004) | (0x0008) | (0x0010) | (0x0020)) & (~(0x00100000L))))
      Which is: 1450
e:\b\c\b\win\src\chrome\browser\media_galleries\media_galleries_test_util.cc(204): error: Expected: registry_override_.OverrideRegistry((( HKEY ) (ULONG_PTR)((LONG)0x80000001) )) doesn't generate new fatal failures in the current thread.
  Actual: it does.
[2408:4500:0522/083750.858:INFO:CONSOLE(0)] "[SUCCESS] ReadDirectoryTest", source: chrome-extension://kanmcaefcmkofcbkonniekomjjojicii/_generated_background_page.html (0)
[2408:4500:0522/083750.898:INFO:CONSOLE(0)] "[SUCCESS] ReadFileToBytesTest", source: chrome-extension://kanmcaefcmkofcbkonniekomjjojicii/_generated_background_page.html (0)
[2408:4500:0522/083750.911:INFO:CONSOLE(0)] "[SUCCESS] GetMediaFileSystemMetadataTest", source: chrome-extension://kanmcaefcmkofcbkonniekomjjojicii/_generated_background_page.html (0)
[  FAILED  ] MediaGalleriesPlatformAppBrowserTest.MediaGalleriesRead, where TypeParam =  and GetParam() =  (759 ms)

Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd922c4e7db002e95868f1596c735954b5f58b42

commit fd922c4e7db002e95868f1596c735954b5f58b42
Author: mek <mek@chromium.org>
Date: Tue May 23 22:43:17 2017

Revert of Disable MediaGalleriesRead on windows. (patchset #1 id:1 of https://codereview.chromium.org/2898153003/ )

Reason for revert:
Should not have been disabled, since this is an infra problem.

Original issue's description:
> Disable MediaGalleriesRead on windows.
>
> BUG= 725354 
> TBR=reillyg@chromium.org
>
> Review-Url: https://codereview.chromium.org/2898153003
> Cr-Commit-Position: refs/heads/master@{#474040}
> Committed: https://chromium.googlesource.com/chromium/src/+/fbd234bbc5db56845bf5dbff315f850b44643014

TBR=reillyg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 725354 

Review-Url: https://codereview.chromium.org/2900213002
Cr-Commit-Position: refs/heads/master@{#474090}

[modify] https://crrev.com/fd922c4e7db002e95868f1596c735954b5f58b42/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

Comment 5 by gab@chromium.org, May 23 2017

Mergedinto: 721245
Status: Duplicate (was: Untriaged)

Sign in to add a comment