Hide Request Mobile Site UI for M59 release |
||||||
Issue descriptionThis feature is meant to be released in M60, however, accidentally leaked into M59. Per offline discussions, a cleaner way to "revert" the feature would be making the minimal number of changes to hide the "Request Mobile Site" UI and disable related tests.
,
May 23 2017
,
May 26 2017
,
May 26 2017
This bug requires manual review: Less than 7 days to go before AppStore submit on M59 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 26 2017
,
May 26 2017
Verified in 60.0.3112.0 Canary, iPhone 6 plus iOS 10.2.1, iPad mini 10.3, Request Mobile Site is hidden from the UI, Looks good.
,
May 26 2017
Thank you for the update Sharon!
,
May 26 2017
Here is the CL https://chromium-review.googlesource.com/c/514583/ to hide the UI of Request Mobile Site, it's intended to not have any visible user impact, and manual testings are requested to make sure that once "Request Desktop Site" button is clicked, the tools menu shows greyed out "Request Desktop Site" instead of "Request Mobile Site".
,
May 26 2017
Verified in iPhone 5S iOS 9.3.4, iPad mini 9.3.5, also preformed upgrade testing. Looks good.
,
May 29 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2017
59.0.3071.75 and later should have this change merged in - it's ready for verification testing now.
,
May 30 2017
"Request Mobile Site" UI is not displayed on M59.0.3071.81 Verified on iPhone6+, iPhone7+, iPad Pro iOS: 9.3.5, 10.3.3, 10.1.1
,
Jun 1 2017
Hi, Has the postmortem for this been circulated yet? Thanks,
,
Jun 1 2017
Thanks for checking in! Drafted it out, will send it out once Jason has done a first pass review.
,
Jun 2 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jasonkliu@chromium.org
, May 23 2017