See Slide 18 on https://docs.google.com/presentation/d/1p9G33j1FNmoeI5jwcqFjBRC1Vm1TbpsJZktwJCXgim0/edit#slide=id.g220462f0cf_0_12 for mocks.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40ce67dbab5aa8bc40a9617f1742b9483ce60a0c commit 40ce67dbab5aa8bc40a9617f1742b9483ce60a0c Author: Angela S <angelashao@google.com> Date: Wed May 31 22:46:12 2017 chrome/android: Add events for data saver in product help. We need the following events to be able to know when the Data Saver App menu in-product help UI should be triggered. This patch plumbs events necessary for it to the FeatureEngagementTracker. The DATA_SAVED_ON_PAGE_LOAD event is tracked when data is saved between the start and end of a page load. It is fine that this event is tracked when multiple tabs load data at the same time (i.e. data may have been saved by a page different from the page this event is tracked) because the goal is just to track how much the data saver is used at a time. The OVERFLOW_OPENED_WITH_DATA_SAVER_SHOWN event is tracked when the overflow menu is opened while the data saver is on/shown. This is to track that the user sees the Data Saver feature (but has not necessarily used it). The DATA_SAVER_DETAIL_OPENED event is tracked when the Data Saver footer is tapped on to open the data saver detail. This is to track the usage of this feature. BUG= 725311 Change-Id: I519eec758fc0b24b49f6c5dfdb6bf7d9a9ae9f9a Reviewed-on: https://chromium-review.googlesource.com/515722 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Angela Shao <angelashao@google.com> Cr-Commit-Position: refs/heads/master@{#476072} [modify] https://crrev.com/40ce67dbab5aa8bc40a9617f1742b9483ce60a0c/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionMainMenuFooter.java [modify] https://crrev.com/40ce67dbab5aa8bc40a9617f1742b9483ce60a0c/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/40ce67dbab5aa8bc40a9617f1742b9483ce60a0c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/40ce67dbab5aa8bc40a9617f1742b9483ce60a0c/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f509287ecc71c3b3c958b7081354590356690efd commit f509287ecc71c3b3c958b7081354590356690efd Author: Angela S <angelashao@google.com> Date: Tue Jun 06 02:06:12 2017 chrome/android: Add feature for data saver in-product help. We need to check whether to trigger the Data Saver app menu in-product help UI when a page load finishes. This patch checks that and displays the data saver in-product help UI. BUG= 725311 Change-Id: I2cacc80372e4ff9424ab5dae544e916a4e9965ec Reviewed-on: https://chromium-review.googlesource.com/518347 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Angela Shao <angelashao@google.com> Cr-Commit-Position: refs/heads/master@{#477154} [modify] https://crrev.com/f509287ecc71c3b3c958b7081354590356690efd/chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java [modify] https://crrev.com/f509287ecc71c3b3c958b7081354590356690efd/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/f509287ecc71c3b3c958b7081354590356690efd/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/f509287ecc71c3b3c958b7081354590356690efd/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/FeatureConstants.java [modify] https://crrev.com/f509287ecc71c3b3c958b7081354590356690efd/components/feature_engagement_tracker/public/feature_constants.cc [modify] https://crrev.com/f509287ecc71c3b3c958b7081354590356690efd/components/feature_engagement_tracker/public/feature_constants.h [modify] https://crrev.com/f509287ecc71c3b3c958b7081354590356690efd/components/feature_engagement_tracker/public/feature_list.cc [modify] https://crrev.com/f509287ecc71c3b3c958b7081354590356690efd/components/feature_engagement_tracker/public/feature_list.h
Issue 723008 has been merged into this issue.
Comment 1 by bugdroid1@chromium.org
, May 31 2017