Parsing error in tools/metrics/histograms/histograms.xml |
|||
Issue descriptiontools\metrics\histograms/pretty_print.py fails to parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This needs to be fixed!
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9f94c9184a56421696578030d7621823b17a39a commit f9f94c9184a56421696578030d7621823b17a39a Author: chengx <chengx@chromium.org> Date: Tue May 23 15:12:18 2017 Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py fails to parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fixes "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py formats a few other lines of code. This CL keeps this change. BUG= 725310 Review-Url: https://codereview.chromium.org/2896953002 Cr-Commit-Position: refs/heads/master@{#473900} [modify] https://crrev.com/f9f94c9184a56421696578030d7621823b17a39a/tools/metrics/histograms/histograms.xml
,
May 23 2017
,
May 23 2017
FYI
,
May 23 2017
Issue 725687 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by chengx@chromium.org
, May 23 2017