New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725309 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

UMA stats for SharedArrayBuffer

Project Member Reported by binji@chromium.org, May 23 2017

Issue description

We should have stats on SharedArrayBuffer usage.

I've assigned you Karl, since you've done this for WebAssembly before -- I hope that's OK! :-)
 
Start by adding a UMA histogram on the sizes of shared array buffers (in kilobytes). Note: This will also show how often shared array buffers are used.
Changing measurement to be in Mb, to follow other array buffer measurements.
Project Member

Comment 3 by bugdroid1@chromium.org, May 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bec7087d3eb468bed72e4e39478edf7c57acf298

commit bec7087d3eb468bed72e4e39478edf7c57acf298
Author: kschimpf <kschimpf@chromium.org>
Date: Sat May 27 01:26:17 2017

Add V8 shared array allocation sizes histogram.

Add histogram to track sizes of shared array buffers in JS.

Associated with V8 CL: https://codereview.chromium.org/2902773002

BUG= chromium:725309 

Review-Url: https://codereview.chromium.org/2898953003
Cr-Commit-Position: refs/heads/master@{#475198}

[modify] https://crrev.com/bec7087d3eb468bed72e4e39478edf7c57acf298/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/86f95d87b946173baeee87c35d1765308b5012e0

commit 86f95d87b946173baeee87c35d1765308b5012e0
Author: kschimpf <kschimpf@chromium.org>
Date: Mon May 29 18:19:33 2017

Add V8 shared array allocation sizes histogram.

Add histogram to track sizes of share array buffers in Wasm/Js.

Associated with Chrome CL: https://codereview.chromium.org/2898953003

BUG= chromium:725309 

Review-Url: https://codereview.chromium.org/2902773002
Cr-Commit-Position: refs/heads/master@{#45577}

[modify] https://crrev.com/86f95d87b946173baeee87c35d1765308b5012e0/src/counters.h
[modify] https://crrev.com/86f95d87b946173baeee87c35d1765308b5012e0/src/objects.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/86f95d87b946173baeee87c35d1765308b5012e0

commit 86f95d87b946173baeee87c35d1765308b5012e0
Author: kschimpf <kschimpf@chromium.org>
Date: Mon May 29 18:19:33 2017

Add V8 shared array allocation sizes histogram.

Add histogram to track sizes of share array buffers in Wasm/Js.

Associated with Chrome CL: https://codereview.chromium.org/2898953003

BUG= chromium:725309 

Review-Url: https://codereview.chromium.org/2902773002
Cr-Commit-Position: refs/heads/master@{#45577}

[modify] https://crrev.com/86f95d87b946173baeee87c35d1765308b5012e0/src/counters.h
[modify] https://crrev.com/86f95d87b946173baeee87c35d1765308b5012e0/src/objects.cc

Status: Fixed (was: Assigned)

Sign in to add a comment