New issue
Advanced search Search tips

Issue 725305 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

arc: Invalidate icons on update

Project Member Reported by khmel@chromium.org, May 23 2017

Issue description

Inner bug: b/33408347

Icons should be invalidated and updated automatically in app list and shelf once package is updated.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f90c7dc31ae659ff560baebcabfe24c3e036312

commit 1f90c7dc31ae659ff560baebcabfe24c3e036312
Author: khmel <khmel@chromium.org>
Date: Wed May 24 22:18:18 2017

arc: Invalide app icon on package update.

ARC app icons need to be invalidated and app icon in app launcher and in
shelf should be automatically updated.

BUG= 725305 
TEST=Manually + unit tests.

Review-Url: https://codereview.chromium.org/2896973002
Cr-Commit-Position: refs/heads/master@{#474443}

[modify] https://crrev.com/1f90c7dc31ae659ff560baebcabfe24c3e036312/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/1f90c7dc31ae659ff560baebcabfe24c3e036312/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Comment 2 by khmel@chromium.org, May 25 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c92801611913812574def15a03f9ad04b08e9af5

commit c92801611913812574def15a03f9ad04b08e9af5
Author: khmel <khmel@chromium.org>
Date: Thu May 25 01:46:55 2017

Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of https://codereview.chromium.org/2896973002/ )

Reason for revert:
Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG= 725305 
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed: https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabfe24c3e036312

TBR=xiyuan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 725305 

Review-Url: https://codereview.chromium.org/2896323004
Cr-Commit-Position: refs/heads/master@{#474516}

[modify] https://crrev.com/c92801611913812574def15a03f9ad04b08e9af5/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/c92801611913812574def15a03f9ad04b08e9af5/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Comment 4 by khmel@chromium.org, May 25 2017

Status: Started (was: Fixed)

Comment 5 by khmel@chromium.org, May 25 2017

Labels: -M-59 M-60
Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7355fde0d4368c35211724de3d11cbb77417aa49

commit 7355fde0d4368c35211724de3d11cbb77417aa49
Author: khmel <khmel@chromium.org>
Date: Thu May 25 16:55:19 2017

Reland "arc: Invalidate app icon on package update."

BUG= 725305 

> Revert of arc: Invalide app icon on package update. (patchset #2 id:20001 of https://codereview.chromium.org/2896973002/ )

> Reason for revert:
> Will take a look mem issue

Original issue's description:
> arc: Invalide app icon on package update.
>
> ARC app icons need to be invalidated and app icon in app launcher and in
> shelf should be automatically updated.
>
> BUG= 725305 
> TEST=Manually + unit tests.
>
> Review-Url: https://codereview.chromium.org/2896973002
> Cr-Commit-Position: refs/heads/master@{#474443}
> Committed: https://chromium.googlesource.com/chromium/src/+/1f90c7dc31ae659ff560baebcabfe24c3e036312

Review-Url: https://codereview.chromium.org/2908483002
Cr-Commit-Position: refs/heads/master@{#474677}

[modify] https://crrev.com/7355fde0d4368c35211724de3d11cbb77417aa49/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/7355fde0d4368c35211724de3d11cbb77417aa49/chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Comment 7 by khmel@chromium.org, May 25 2017

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74a7be1474c1aca878310bbba0b0a3c4362e2220

commit 74a7be1474c1aca878310bbba0b0a3c4362e2220
Author: khmel <khmel@google.com>
Date: Tue May 30 18:45:31 2017

arc: Ignore icon invalidation on Play Store update.

This prevent updating Play Store icon once its package has been
updated.

TEST=Manually
BUG= 725305 

Change-Id: Ie06725f83740d6e2ae8bd304b173dc5a0b0bd04f
Reviewed-on: https://chromium-review.googlesource.com/517702
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475609}
[modify] https://crrev.com/74a7be1474c1aca878310bbba0b0a3c4362e2220/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

Comment 9 by khmel@chromium.org, May 30 2017

Status: Started (was: Fixed)
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 1 2017

Labels: merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc6507bb54fe08517288d2f30db689f3bf46b707

commit dc6507bb54fe08517288d2f30db689f3bf46b707
Author: khmel <khmel@chromium.org>
Date: Thu Jun 01 01:17:17 2017

[Merge M60] arc: Ignore icon invalidation on Play Store update.

This prevent updating Play Store icon once its package has been
updated.

TEST=Manually
BUG= 725305 
TBR=xiyuan@chromium.org
NOTRY=true
NOPRESUBMIT=true

Change-Id: Ie06725f83740d6e2ae8bd304b173dc5a0b0bd04f
Reviewed-on: https://chromium-review.googlesource.com/517702
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#475609}
Review-Url: https://codereview.chromium.org/2914993002
Cr-Commit-Position: refs/branch-heads/3112@{#77}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/dc6507bb54fe08517288d2f30db689f3bf46b707/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

Status: Fixed (was: Started)

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment