should show all accepted card icon in payment editor. |
||||||
Issue descriptionChrome Version: 60.0.3107.0 (Official Build) canary (32bit) OS: android 7.0.0; SM-G930L What steps will reproduce the problem? (1) go https://paymentrequest.show/demo/ (2) choose all cards. (3) click buy button. (4) enter card editor in Payment Request UI. What is the expected result? should show all accepted card icons in payment editor. What happens instead? some accepted cards are missed. when landscapte mode, all accepted cards are appeared. i think accepted card icons are missed in portrait mode according devices resolution.
,
May 23 2017
,
May 23 2017
Go ahead. What's your plan?
,
May 23 2017
present, icons are in LinearLayout. i will replace LinearLayout with GridView. if can't show all card icons in one line, GridView will make more than two lines.
,
May 23 2017
devices resolutions are different each other. and i think new cards might be added at browser at future. we can't adjust icon size to fit layout every time. so i think we don't have to show icons in the one line.
,
May 23 2017
,
May 23 2017
How will you determine the number of columns in your grid view?
,
May 23 2017
i will set auto_fit at android:numColumns of GridView. (https://developer.android.com/reference/android/widget/GridView.html) it will determin the proper number of columns automatically in android platform side.
,
May 23 2017
i'm working in process in (https://codereview.chromium.org/2902503002/) i attach one screenshot which replaced with GridView. is it look like good to you?
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/117a4a82c42bcc441a7d5f21ab76b3e37fcbe6ef commit 117a4a82c42bcc441a7d5f21ab76b3e37fcbe6ef Author: hs1217.lee <hs1217.lee@samsung.com> Date: Tue Jun 06 12:52:41 2017 [Payment] should show all accepted card icon in payment editor. accepted card icons are missed in portrait mode according devices resolution. so we should replace LinearLayout with GridView to show all accepted card icons. if can't show all card icons in one line, GridView will make more then two lines. BUG= 725296 Review-Url: https://codereview.chromium.org/2902503002 Cr-Commit-Position: refs/heads/master@{#477268} [modify] https://crrev.com/117a4a82c42bcc441a7d5f21ab76b3e37fcbe6ef/chrome/android/java/res/layout/payment_request_editor_icons.xml [modify] https://crrev.com/117a4a82c42bcc441a7d5f21ab76b3e37fcbe6ef/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java [add] https://crrev.com/117a4a82c42bcc441a7d5f21ab76b3e37fcbe6ef/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ExpandableGridView.java [modify] https://crrev.com/117a4a82c42bcc441a7d5f21ab76b3e37fcbe6ef/chrome/android/java_sources.gni
,
Jun 7 2017
,
Jun 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hs1217....@samsung.com
, May 23 2017