This bug tracks the CLs and the work needed for adding layout tests for the network quality extension to the NetInfo API. current spec draft: https://cdn.rawgit.com/WICG/netinfo/ect/index.html WICG discussion: https://github.com/WICG/netinfo/issues/46 blink-dev i2s thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/UVfNMH50aaQ
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f51122ff533e752a86a27193ca7539c450b3670e commit f51122ff533e752a86a27193ca7539c450b3670e Author: tbansal <tbansal@chromium.org> Date: Fri Jun 02 07:00:38 2017 NetInfo network quality extension: Add callbacks and Layout tests "change" event is fired from NetworkInformation.cpp when there is a change in the network quality. Also, layout tests have been added for the network quality extension to the NetInfo API. BUG= 725282 , 726762 Review-Url: https://codereview.chromium.org/2903493002 Cr-Commit-Position: refs/heads/master@{#476595} [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/basic-operation-expected.txt [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/basic-operation.html [add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation-expected.txt [add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation.html [add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames-expected.txt [add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames.html [add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-web-worker-expected.txt [add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/estimate-web-worker.html [add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/network-quality-expected.txt [add] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/network-quality.html [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/resources/web-worker.js [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener-expected.txt [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/unregister-during-event-expected.txt [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/LayoutTests/netinfo/web-worker.html [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/core/html/HTMLMediaElementTest.cpp [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/core/testing/Internals.h [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/core/testing/Internals.idl [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/platform/network/NetworkStateNotifier.h [modify] https://crrev.com/f51122ff533e752a86a27193ca7539c450b3670e/third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52551041771eca1ec73306e43c9ad370b7131887 commit 52551041771eca1ec73306e43c9ad370b7131887 Author: Tarun Bansal <tbansal@google.com> Date: Tue Jun 06 20:20:21 2017 NetInfo network quality extension: Add callbacks and Layout tests "change" event is fired from NetworkInformation.cpp when there is a change in the network quality. Also, layout tests have been added for the network quality extension to the NetInfo API. BUG= 725282 , 726762 Review-Url: https://codereview.chromium.org/2903493002 Cr-Original-Commit-Position: refs/heads/master@{#476595} Review-Url: https://codereview.chromium.org/2924913002 . Cr-Commit-Position: refs/branch-heads/3112@{#204} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/basic-operation-expected.txt [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/basic-operation.html [add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation-expected.txt [add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation.html [add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames-expected.txt [add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames.html [add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-web-worker-expected.txt [add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/estimate-web-worker.html [add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/network-quality-expected.txt [add] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/network-quality.html [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/resources/web-worker.js [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener-expected.txt [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/unregister-during-event-expected.txt [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/LayoutTests/netinfo/web-worker.html [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/core/html/HTMLMediaElementTest.cpp [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/core/testing/Internals.h [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/core/testing/Internals.idl [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/platform/network/NetworkStateNotifier.h [modify] https://crrev.com/52551041771eca1ec73306e43c9ad370b7131887/third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
Comment 1 by bengr@chromium.org
, May 23 2017