New issue
Advanced search Search tips

Issue 725278 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

add scroll anchoring tests to web-platform-tests

Project Member Reported by skobes@chromium.org, May 22 2017

Issue description

Scroll anchoring tests currently live mostly in ScrollAnchorTest.cpp with a few layout tests in LayoutTests/fast/layout/scroll-anchoring.

We should add as many of these as possible to the web-platform-tests repository mirrored in LayoutTests/external/wpt, to assist other browsers who may implement scroll anchoring.

This issue is also filed in the scroll anchoring github as https://github.com/WICG/ScrollAnchoring/issues/3.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2017

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcbddb1c21c2932748797c0cc2e2c62d162da9f2

commit fcbddb1c21c2932748797c0cc2e2c62d162da9f2
Author: Steve Kobes <skobes@chromium.org>
Date: Mon Jun 05 22:01:03 2017

Finish converting scroll anchoring tests to web-platform-tests.

The mapping from gTest to WPT filenames is shown at:
  http://bit.ly/scroll-anchoring-wpt-conversions

Many tests have been updated or substantially rewritten to expand coverage and
to express their intent in terms of platform behavior.  In some cases, two or
more test cases were combined into one.

Most of the converted tests have been deleted from ScrollAnchorTest.  A few
tests remain in ScrollAnchorTest alongside or without conversion, because they
verify implementation-specific aspects of scroll anchoring, such as metrics,
anchor node caching, PaintLayer interactions, or flexbox delayed-clamping logic.

Bug:  725278 
Change-Id: I518baba66b4a20c6117e5bcaf7f8db2f2f4f26b8
Reviewed-on: https://chromium-review.googlesource.com/517774
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477092}
[modify] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/abspos-containing-block-outside-scroller.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/abspos-contributes-to-static-parent-bounds.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/ancestor-change-heuristic.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/anchor-updates-after-explicit-scroll.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/anchoring-with-bounds-clamping-div.html
[modify] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/anchoring-with-bounds-clamping.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/anonymous-block-box.html
[modify] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/basic.html
[modify] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/clipped-scrollers-skipped.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/descend-into-container-with-float.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/descend-into-container-with-overflow.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/exclude-fixed-position.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/inline-block.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/negative-layout-overflow.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/opt-out.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/position-change-heuristic.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/start-edge-in-block-layout-direction.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/subtree-exclusion.html
[add] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/LayoutTests/external/wpt/scroll-anchoring/wrapped-text.html
[modify] https://crrev.com/fcbddb1c21c2932748797c0cc2e2c62d162da9f2/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment