Remove IPC enums in chrome_extension_messages.h |
|||
Issue descriptionRemove the following IPC_ENUM_TRAITS from chrome_extension_messages.h: IPC_ENUM_TRAITS_MAX_VALUE(extensions::api::webstore::InstallStage, extensions::api::webstore::INSTALL_STAGE_INSTALLING) IPC_ENUM_TRAITS_MAX_VALUE(extensions::webstore_install::Result, extensions::webstore_install::RESULT_LAST) Removing the ipc enums results from the file today results in the following linker error: ../../mojo/public/cpp/bindings/lib/native_enum_serialization.h:34: error: undefined reference to 'IPC::ParamTraits<extensions::api::webstore::InstallStage>::Write(base::Pickle*, extensions::api::webstore::InstallStage const&)' ../../mojo/public/cpp/bindings/lib/native_enum_serialization.h:53: error: undefined reference to 'IPC::ParamTraits<extensions::api::webstore::InstallStage>::Read(base::Pickle const*, base::PickleIterator*, extensions::api::webstore::InstallStage*)' ../../mojo/public/cpp/bindings/lib/native_enum_serialization.h:53: error: undefined reference to 'IPC::ParamTraits<extensions::webstore_install::Result>::Read(base::Pickle const*, base::PickleIterator*, extensions::webstore_install::Result*)' ../../mojo/public/cpp/bindings/lib/native_enum_serialization.h:34: error: undefined reference to 'IPC::ParamTraits<extensions::webstore_install::Result>::Write(base::Pickle*, extensions::webstore_install::Result const&)' It will be easier to track down this linker error once all IPCs in chrome_extension_messages.h have been converted and the file is no longer needed.
,
Jun 23 2017
Hey catherine, I think I have a fix for this. Will submit a patch.
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66cb6fb8aeec881dc6b99d6ed3eb1414508f7f53 commit 66cb6fb8aeec881dc6b99d6ed3eb1414508f7f53 Author: karandeepb <karandeepb@chromium.org> Date: Mon Jun 26 19:41:27 2017 Extensions: Remove duplicate IPC enums in chrome_extension_messages.h. This CL removes duplicate webstore::InstallStage and webstore_install::Result IPC enums from chrome_extension_messages.h. Removing these caused a linker error since IPC::ParamTraits specialization for these were not being generated. Fix this by generating them as part of common_message_generator. BUG= 725275 Review-Url: https://codereview.chromium.org/2955543002 Cr-Commit-Position: refs/heads/master@{#482359} [modify] https://crrev.com/66cb6fb8aeec881dc6b99d6ed3eb1414508f7f53/chrome/common/common_message_generator.h [modify] https://crrev.com/66cb6fb8aeec881dc6b99d6ed3eb1414508f7f53/chrome/common/extensions/chrome_extension_messages.h [modify] https://crrev.com/66cb6fb8aeec881dc6b99d6ed3eb1414508f7f53/chrome/common/extensions/mojom/inline_install_traits.h
,
Jun 26 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by catmulli...@chromium.org
, May 22 2017