Support NV12 textures in VideoTrackRecorder |
|||||
Issue descriptionWindows H264 decoder can output NV12 textures. We should support encoding those in VideoTrackRecorder.
,
May 23 2017
,
May 23 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 23 2017
Is this required for M59 or can we wait until M60? We are actually only a week away from stable release. Is this a safe merge? Has this been tested in canary yet?
,
May 23 2017
This breaks MediaRecorder functionality when HW decoded video is to be recorded. NV12 output type is newly added, but the developer of the CLs didn't catch this NOTREACHED() because we don't have bots that do HW decode. It is a one line CL that is safe to merge and tested locally.
,
May 23 2017
Based on comment 5, approving merge for M59. Please go ahead and merge to 3071.
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e56533d27c4a2cec1698b97fe8979eff4201eed2 commit e56533d27c4a2cec1698b97fe8979eff4201eed2 Author: emircan <emircan@chromium.org> Date: Tue May 23 23:21:59 2017 Merge 59: Support NV12 textures in VideoTrackRecorder Bug: 725274 Test: Tested on Win H264 decoded output. Change-Id: I65695e763110d13e3d698c0b288272d511df676f Reviewed-on: https://chromium-review.googlesource.com/511188 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#473820} Review-Url: https://codereview.chromium.org/2901863003 Cr-Commit-Position: refs/branch-heads/3071@{#679} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/e56533d27c4a2cec1698b97fe8979eff4201eed2/content/renderer/media_recorder/video_track_recorder.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, May 23 2017