New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 725267 link

Starred by 4 users
Status: Fixed
Owner:
weili@chromium.org
Closed: May 2017
Cc:
█ abdulsyed@chromium.org
pbomm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome PDF Viewer (Beta/ Dev) does not support 256-bit AES (level 8) PDF

Project Member Reported by thestig@chromium.org, May 22 2017 
Chrome Version: 59.x, 60.x

What steps will reproduce the problem?
(1) See https://bugs.chromium.org/p/pdfium/issues/detail?id=727

We need to merge the fix for the above PDFium bug to M59.
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/355954b8f09a65934b95dd6ca1299a73ae5e24b2

commit 355954b8f09a65934b95dd6ca1299a73ae5e24b2
Author: Wei Li <weili@chromium.org>
Date: Mon May 22 23:01:53 2017

Fix crypto calculation regression due to typo

Use the correct values to calculate SHA512.

BUG= pdfium:727 , chromium:725267 

Change-Id: I63d257c1df6304019a70f53df4653d358d3db525
Reviewed-on: https://pdfium-review.googlesource.com/5770
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/355954b8f09a65934b95dd6ca1299a73ae5e24b2/core/fdrm/crypto/fx_crypt_unittest.cpp
[modify] https://crrev.com/355954b8f09a65934b95dd6ca1299a73ae5e24b2/core/fdrm/crypto/fx_crypt_sha.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b53c67659b98f640f9a50f54599ca90150eab18

commit 6b53c67659b98f640f9a50f54599ca90150eab18
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Tue May 23 01:31:19 2017

Roll src/third_party/pdfium/ ed75ee25f..355954b8f (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/ed75ee25f40a..355954b8f09a

$ git log ed75ee25f..355954b8f --date=short --no-merges --format='%ad %ae %s'
2017-05-22 weili Fix crypto calculation regression due to typo

Created with:
  roll-dep src/third_party/pdfium
BUG= 725267 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Iad57886e1fbfd37c21a956653333f1d820415c46
Reviewed-on: https://chromium-review.googlesource.com/511187
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473776}
[modify] https://crrev.com/6b53c67659b98f640f9a50f54599ca90150eab18/DEPS

Comment 3 by thestig@chromium.org, May 23 2017 

We need to wait another day or two and check Canary 60.0.3109.0 or newer to verify it's fixed, before requesting a merge to M59.

Comment 4 by thestig@chromium.org, May 23 2017

Cc: abdulsyed@chromium.org pbomm...@chromium.org
 Issue 724100  has been merged into this issue.

Comment 5 by thestig@chromium.org, May 23 2017

Labels: Merge-Request-59
I verified the fix on trunk, since we don't have a Canary to check yet.

Comment 6 by abdulsyed@chromium.org, May 23 2017 

Approving merge for M59.

Comment 7 by abdulsyed@chromium.org, May 23 2017

Labels: -Merge-Request-59 Merge-Approved-59
Project Member

Comment 8 by bugdroid1@chromium.org, May 23 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/4d46901fe4ef3491bdb4375519b488de0142398e

commit 4d46901fe4ef3491bdb4375519b488de0142398e
Author: Lei Zhang <thestig@chromium.org>
Date: Tue May 23 23:37:18 2017

M59: Fix crypto calculation regression due to typo

Use the correct values to calculate SHA512.

BUG= pdfium:727 , chromium:725267 

TBR=weili@chromium.org

Change-Id: I7134091debaa04f17865170a4d4d62620062a9a1
Reviewed-on: https://pdfium-review.googlesource.com/5832
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/4d46901fe4ef3491bdb4375519b488de0142398e/core/fdrm/crypto/fx_crypt_unittest.cpp
[modify] https://crrev.com/4d46901fe4ef3491bdb4375519b488de0142398e/core/fdrm/crypto/fx_crypt_sha.cpp

Comment 9 by thestig@chromium.org, May 23 2017

Status: Fixed (was: Started)
►

Sign in to add a comment