Move layout tests using js-test.js to webaudio/legacy directory. |
|||
Issue descriptionThe following tests are still using js-test.js: third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource.html:10 third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-detached-no-crash.html:7 third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-detached-no-crash.html:7 third_party/WebKit/LayoutTests/webaudio/internals/audiocontext-lock-threading-race.html:7 third_party/WebKit/LayoutTests/webaudio/internals/cycle-connection-gc.html:7 third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-gc.html:7 third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-wrapper.html:7 third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-premature-death.html:7 Move them to webaudio/legacy directory with a README.md.
,
May 30 2017
I think "legacy" has the wrong connotation. The tests are still valid, just using js-test instead of testharness.
,
May 30 2017
"legacy" does not necessarily mean that they are wrong. Becauase js-test is deprecated, so here it means they won't be maintained/expanded/upstreamed in the future. I used the term "legacy" in that sense.
,
May 30 2017
Maybe just name it js-tests then? That's pretty clear and free of connotations.
,
Jul 14 2017
So is js-tests/ good enough and leave internals/ as they are?
,
Jul 28 2017
Okay, I am moving test files using js-test.js to webaudio/internals/.
,
Jul 28 2017
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29e96c352c11ed53811bccbc3cf95701d71fd5bb commit 29e96c352c11ed53811bccbc3cf95701d71fd5bb Author: Hongchan Choi <hongchan@chromium.org> Date: Fri Jul 28 21:27:10 2017 Move layout tests using js-test.js to webaudio/internals For upstreaming layout tests to the WPT suite, we need to move test files use outdated js-test.js to webaudio/internals/. Bug: 725259 Change-Id: Ic282d0ee6087cb351bbec4d03961e9642347e66e Reviewed-on: https://chromium-review.googlesource.com/591921 Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#490512} [modify] https://crrev.com/29e96c352c11ed53811bccbc3cf95701d71fd5bb/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [rename] https://crrev.com/29e96c352c11ed53811bccbc3cf95701d71fd5bb/third_party/WebKit/LayoutTests/webaudio/internals/audiobuffersource-expected.wav [rename] https://crrev.com/29e96c352c11ed53811bccbc3cf95701d71fd5bb/third_party/WebKit/LayoutTests/webaudio/internals/audiobuffersource.html [rename] https://crrev.com/29e96c352c11ed53811bccbc3cf95701d71fd5bb/third_party/WebKit/LayoutTests/webaudio/internals/offlineaudiocontext-detached-no-crash-expected.txt [rename] https://crrev.com/29e96c352c11ed53811bccbc3cf95701d71fd5bb/third_party/WebKit/LayoutTests/webaudio/internals/offlineaudiocontext-detached-no-crash.html [rename] https://crrev.com/29e96c352c11ed53811bccbc3cf95701d71fd5bb/third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-detached-no-crash-expected.txt [rename] https://crrev.com/29e96c352c11ed53811bccbc3cf95701d71fd5bb/third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-detached-no-crash.html [rename] https://crrev.com/29e96c352c11ed53811bccbc3cf95701d71fd5bb/third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-rewrap-expected.txt [rename] https://crrev.com/29e96c352c11ed53811bccbc3cf95701d71fd5bb/third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-rewrap.html
,
Jul 28 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rtoy@chromium.org
, May 22 2017