is smogcheck still being used?

there are some autotests referring to it

`equery-$BOARD d smogcheck` didn't turn up anything, could it be that we have a broken dependency?

i could only find TPM users in autotests.  whether those are dead, or only run on demand, i'm not sure.  since smogcheck is basically an I2C library interface that is designed to be faster than i2c-tools, but TPM's are, by design, slow, maybe we can convert those few autotest users over to i2c-tools and accept the overhead.

either way, cleaning up smogcheck enough to not block other things was fairly easy, so i just did it :).

My main concern isn't about the cleanup, but about not having smogcheck being built at all (due to the missing dependency), so we don't know when it breaks

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/46d0f68227e59196a27a6270f64ed070d252e709

commit 46d0f68227e59196a27a6270f64ed070d252e709
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 24 06:58:58 2017

smogcheck: add proper extern C markings

This makes the library usable from C++ code.

BUG= chromium:725253 
TEST=precq passes

Change-Id: I5df6a645a2dd8b60fb1eb5b282abbe6ccc22f210
Reviewed-on: https://chromium-review.googlesource.com/511463
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/46d0f68227e59196a27a6270f64ed070d252e709/smogcheck/include/lib/lib_smogcheck.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/601cf35f6463e0f09c5dc443042c039706f9d54c

commit 601cf35f6463e0f09c5dc443042c039706f9d54c
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 24 06:58:58 2017

smogcheck: switch to proper uint{8,16}_t types

There's no need to use kernel types directly when userspace already
has standard ones for us.  We also don't like to mix linux & user
headers if we can avoid it.

BUG= chromium:725253 
TEST=precq passes

Change-Id: I43b9a6836ed4eeda2371bb3fefd6cf46bd206c53
Reviewed-on: https://chromium-review.googlesource.com/511464
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/601cf35f6463e0f09c5dc443042c039706f9d54c/smogcheck/lib/lib_smogcheck.c
[modify] https://crrev.com/601cf35f6463e0f09c5dc443042c039706f9d54c/smogcheck/include/lib/lib_smogcheck.h
[modify] https://crrev.com/601cf35f6463e0f09c5dc443042c039706f9d54c/smogcheck/smogcheck.c

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c8386ae1402c604860cc274d17ef4bac637f1052

commit c8386ae1402c604860cc274d17ef4bac637f1052
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 24 06:58:59 2017

smogcheck: move library code to top level

There's no need to keep this in a subdir when there's only two source
files in this entire project.  It also makes building simpler.

BUG= chromium:725253 
TEST=precq passes

Change-Id: Id40eda9ce2ff43b662f45f37cfab82ff8981f69b
Reviewed-on: https://chromium-review.googlesource.com/511465
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[rename] https://crrev.com/c8386ae1402c604860cc274d17ef4bac637f1052/smogcheck/lib_smogcheck.c
[modify] https://crrev.com/c8386ae1402c604860cc274d17ef4bac637f1052/smogcheck/Makefile

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d96ca39d7fae7f5ab7b03e9ce64f580c91794da0

commit d96ca39d7fae7f5ab7b03e9ce64f580c91794da0
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 24 06:58:59 2017

smogcheck: drop unused library linkage

No code uses pthread, clock (rt), or uuid functions, so stop linking
against these libraries.

BUG= chromium:725253 
TEST=precq passes

Change-Id: I6f45f5dac209554f2ed1545814a5ce75bcf440b0
Reviewed-on: https://chromium-review.googlesource.com/511466
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/d96ca39d7fae7f5ab7b03e9ce64f580c91794da0/smogcheck/Makefile

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c100bec47c872e85271e067b8b9f13896b881465

commit c100bec47c872e85271e067b8b9f13896b881465
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 24 06:58:59 2017

smogcheck: ignore compiled code

BUG= chromium:725253 
TEST=precq passes

Change-Id: I5877b82d5647ed97bed844ba192d81de91b5e8b9
Reviewed-on: https://chromium-review.googlesource.com/511467
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[add] https://crrev.com/c100bec47c872e85271e067b8b9f13896b881465/smogcheck/.gitignore

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/64d788907a8716575e80a800de61a1a5be433432

commit 64d788907a8716575e80a800de61a1a5be433432
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jun 02 06:49:35 2017

smogcheck: mark exported library functions as such

This allows us to build with different default visibility flags.

BUG= chromium:725253 
TEST=precq passes

Change-Id: I1289b94f831874e40c14d780c326fd52c9397e67
Reviewed-on: https://chromium-review.googlesource.com/511468
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/64d788907a8716575e80a800de61a1a5be433432/smogcheck/include/lib/lib_smogcheck.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2c73b13dba35ec35941cf02a8b00e76f90fbd6fc

commit 2c73b13dba35ec35941cf02a8b00e76f90fbd6fc
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jun 02 23:59:38 2017

smogcheck: let people set the proper libdir

The proper library path depends on the active ABI, and only the
higher build system (emerge) knows that info.

BUG= chromium:725253 
TEST=precq passes

Change-Id: I87916f50ede4973376ccd81456c9045f38f0f35a
Reviewed-on: https://chromium-review.googlesource.com/511470
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/2c73b13dba35ec35941cf02a8b00e76f90fbd6fc/smogcheck/Makefile

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d3549d5123391ec46daf5ded25569fb3662816f4

commit d3549d5123391ec46daf5ded25569fb3662816f4
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Jun 05 23:39:51 2017

smogcheck: fix install perms

Programs & libraries should be +x on disk.

BUG= chromium:725253 
TEST=precq passes

Change-Id: Ifb83be3feb0a1d48b48ec025ee61c7dd16be48e7
Reviewed-on: https://chromium-review.googlesource.com/511502
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/d3549d5123391ec46daf5ded25569fb3662816f4/smogcheck/Makefile

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d3549d5123391ec46daf5ded25569fb3662816f4

commit d3549d5123391ec46daf5ded25569fb3662816f4
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Jun 05 23:39:51 2017

smogcheck: fix install perms

Programs & libraries should be +x on disk.

BUG= chromium:725253 
TEST=precq passes

Change-Id: Ifb83be3feb0a1d48b48ec025ee61c7dd16be48e7
Reviewed-on: https://chromium-review.googlesource.com/511502
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/d3549d5123391ec46daf5ded25569fb3662816f4/smogcheck/Makefile

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2b238dc1c36fc80dfca4ed3c130214b3a1d481aa

commit 2b238dc1c36fc80dfca4ed3c130214b3a1d481aa
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Feb 23 11:37:11 2018

smogcheck: convert to common.mk

BUG= chromium:725253 
TEST=precq passes

Change-Id: I9f1706efc2108534f336721fc7a109f28f4c832d
Reviewed-on: https://chromium-review.googlesource.com/932181
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/2b238dc1c36fc80dfca4ed3c130214b3a1d481aa/chromeos-base/smogcheck/smogcheck-9999.ebuild