New issue
Advanced search Search tips

Issue 725249 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Overlay scrollbars block the console readline

Project Member Reported by paulir...@chromium.org, May 22 2017

Issue description

Will only be reproducible on a mac.

Log a big array of objects. The preview will go wild and force a horizontal scrollbar.

Then the overlay scrollbar for the window will sit on top of the console readline, which is quite frustrating.
 
Screen Shot 2017-05-22 at 2.54.33 PM.png
363 KB View Download

Comment 1 by l...@chromium.org, May 22 2017

Cc: l...@chromium.org
 Issue 682019  has been merged into this issue.

Comment 2 by l...@chromium.org, May 22 2017

Thanks for the report.  It's especially frustrating when you have text in the prompt, like in your screenshot.

A few options:
- Prevent horizontal scrolling entirely and use text-overflow ellipsis
- Add in some padding under the prompt while scrolling

Comment 4 by l...@chromium.org, Nov 7 2017

 Issue 767618  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06e046ba940fb6dffe3bbed45b85fb840b4a9194

commit 06e046ba940fb6dffe3bbed45b85fb840b4a9194
Author: Erik Luo <luoe@chromium.org>
Date: Tue Apr 17 03:06:58 2018

DevTools: add space-below-prompt experiment

- Adds an empty 15px space directly below the Console
  prompt's editor.
- Updates "isScrolledToBottom" logic in Console to account
  for the new space. Without this update, typing on the
  prompt's last line will not "jump + stick to bottom"
  as expected.

With this CL, overlay scrollbars (e.g. on Mac), should
never cover the prompt's editor.

Bug:  725249 
Change-Id: Ib0167f6919d5b9942e7f2dc4d8cf0c15fc9368df
Reviewed-on: https://chromium-review.googlesource.com/965020
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551222}
[add] https://crrev.com/06e046ba940fb6dffe3bbed45b85fb840b4a9194/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-stick-to-bottom-with-large-prompt-expected.txt
[add] https://crrev.com/06e046ba940fb6dffe3bbed45b85fb840b4a9194/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-stick-to-bottom-with-large-prompt.js
[modify] https://crrev.com/06e046ba940fb6dffe3bbed45b85fb840b4a9194/third_party/blink/renderer/devtools/front_end/console/ConsolePrompt.js
[modify] https://crrev.com/06e046ba940fb6dffe3bbed45b85fb840b4a9194/third_party/blink/renderer/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/06e046ba940fb6dffe3bbed45b85fb840b4a9194/third_party/blink/renderer/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/06e046ba940fb6dffe3bbed45b85fb840b4a9194/third_party/blink/renderer/devtools/front_end/main/Main.js

Comment 6 by l...@chromium.org, May 14 2018

Cc: -l...@chromium.org
Status: Fixed (was: Assigned)
Now that the experiment #5 will be on by default [1], the cursor will never be blocked.  Marking as fixed.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1056398

Sign in to add a comment