Remove -[CRWNativeContentProvider controllerForURL:withError:isPost:] |
||||||||||
Issue descriptionios/web should use HTML error pages provided by WebClient::PrepareErrorPage. This approach matches content and does not use deprecated NativeContent API.
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/517153c7d9b005cc6f7495d759a6e26f9f29ca87 commit 517153c7d9b005cc6f7495d759a6e26f9f29ca87 Author: eugenebut <eugenebut@chromium.org> Date: Wed May 24 22:36:17 2017 Fixed isCurrentNavigationItemPOST for user initiated POSTs. CRWWebController allows post requests in loadWithParams:. Those requests will not create _pendingNavigationInfo but will set HasPostData to navigation item. Checking both _pendingNavigationInfo and HasPostData fixes the problem. Tests will be in a separate CL, which implements NavigaitonContext::IsPost(): https://codereview.chromium.org/2903883002/patch/20001/30004 BUG= 725241 Review-Url: https://codereview.chromium.org/2899193003 Cr-Commit-Position: refs/heads/master@{#474453} [modify] https://crrev.com/517153c7d9b005cc6f7495d759a6e26f9f29ca87/ios/web/web_state/ui/crw_web_controller.mm
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e97865b7bccd9e278a2902b4ae3b0feac0b088c7 commit e97865b7bccd9e278a2902b4ae3b0feac0b088c7 Author: eugenebut <eugenebut@chromium.org> Date: Fri May 26 23:16:28 2017 Added NavigationContext::IsPost. This new API will allow removing -[CRWNativeContentProvider controllerForURL:withError:isPost:] callback and replacing it with general purpose WebStateObserver::DidFinishNavigation that takes NavigationContext. BUG= 725241 Review-Url: https://codereview.chromium.org/2903883002 Cr-Commit-Position: refs/heads/master@{#475177} [modify] https://crrev.com/e97865b7bccd9e278a2902b4ae3b0feac0b088c7/ios/web/public/web_state/navigation_context.h [modify] https://crrev.com/e97865b7bccd9e278a2902b4ae3b0feac0b088c7/ios/web/test/web_int_test.h [modify] https://crrev.com/e97865b7bccd9e278a2902b4ae3b0feac0b088c7/ios/web/test/web_int_test.mm [modify] https://crrev.com/e97865b7bccd9e278a2902b4ae3b0feac0b088c7/ios/web/web_state/navigation_callbacks_inttest.mm [modify] https://crrev.com/e97865b7bccd9e278a2902b4ae3b0feac0b088c7/ios/web/web_state/navigation_context_impl.h [modify] https://crrev.com/e97865b7bccd9e278a2902b4ae3b0feac0b088c7/ios/web/web_state/navigation_context_impl.mm [modify] https://crrev.com/e97865b7bccd9e278a2902b4ae3b0feac0b088c7/ios/web/web_state/navigation_context_impl_unittest.mm [modify] https://crrev.com/e97865b7bccd9e278a2902b4ae3b0feac0b088c7/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/e97865b7bccd9e278a2902b4ae3b0feac0b088c7/ios/web/web_state/web_state_impl_unittest.mm
,
Jun 1 2017
Can be easily removed after switching to the new architecture.
,
Jun 1 2017
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13b6a0f2fb8045004e2cd77c7e72947bae064d02 commit 13b6a0f2fb8045004e2cd77c7e72947bae064d02 Author: eugenebut <eugenebut@chromium.org> Date: Fri Jun 02 16:49:54 2017 Deprecated -[CRWNativeContentProvider controllerForURL:withError:isPost:] Clients must use WebStateObserver::DidFinishNavigation and check for NavigationContext::GetError() and NavigationContext::IsPost(). Change just marks the method as deprecated, but doesn't change any actual code. BUG= 725241 Review-Url: https://codereview.chromium.org/2907723003 Cr-Commit-Position: refs/heads/master@{#476692} [modify] https://crrev.com/13b6a0f2fb8045004e2cd77c7e72947bae064d02/ios/web/public/web_state/ui/crw_native_content_provider.h
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02bddfd9587ac7bb74b5e4cc756b669dada3184c commit 02bddfd9587ac7bb74b5e4cc756b669dada3184c Author: Eugene But <eugenebut@chromium.org> Date: Fri Nov 17 16:20:05 2017 Fixed Navigation callbacks for failed provisional navigation. Verified callbacks correctness with NavigationCallbacksTest.FailedNavigation integration test. Before this CL DidStartNavigation was called twice (second time for presenting error in Native Content). DidFinishNavigation was called once (also for presenting NativeContent). First DidStartNavigation did not have a matching DidStartNavigation call. This CL removes DidStartNavigation/DidFinishNavigation callbacks for for presenting error in Native Content and adds balanced DidFinishNavigation callback in handleLoadingError:. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id15ef8c9422e571f74f9c00bf88ea98ccbf6607c Reviewed-on: https://chromium-review.googlesource.com/758718 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#517420} [modify] https://crrev.com/02bddfd9587ac7bb74b5e4cc756b669dada3184c/ios/web/public/test/fakes/test_native_content_provider.mm [modify] https://crrev.com/02bddfd9587ac7bb74b5e4cc756b669dada3184c/ios/web/web_state/navigation_callbacks_inttest.mm [modify] https://crrev.com/02bddfd9587ac7bb74b5e4cc756b669dada3184c/ios/web/web_state/ui/crw_web_controller.mm
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/733b148a005e70786525f314e02a81c7a347ffc4 commit 733b148a005e70786525f314e02a81c7a347ffc4 Author: Eugene But <eugenebut@chromium.org> Date: Fri Nov 17 18:29:34 2017 Revert "Fixed Navigation callbacks for failed provisional navigation." This reverts commit 02bddfd9587ac7bb74b5e4cc756b669dada3184c. Reason for revert: Breaks device bots tests Original change's description: > Fixed Navigation callbacks for failed provisional navigation. > > Verified callbacks correctness with > NavigationCallbacksTest.FailedNavigation integration test. > > Before this CL DidStartNavigation was called twice (second time > for presenting error in Native Content). DidFinishNavigation was > called once (also for presenting NativeContent). First > DidStartNavigation did not have a matching DidStartNavigation > call. > > This CL removes DidStartNavigation/DidFinishNavigation callbacks > for for presenting error in Native Content and adds balanced > DidFinishNavigation callback in handleLoadingError:. > > Bug: 725241 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Id15ef8c9422e571f74f9c00bf88ea98ccbf6607c > Reviewed-on: https://chromium-review.googlesource.com/758718 > Commit-Queue: Eugene But <eugenebut@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517420} TBR=eugenebut@chromium.org,kkhorimoto@chromium.org Change-Id: I6c21310e2f1893fead293ca3808b680a4ae910b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/777240 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517478} [modify] https://crrev.com/733b148a005e70786525f314e02a81c7a347ffc4/ios/web/public/test/fakes/test_native_content_provider.mm [modify] https://crrev.com/733b148a005e70786525f314e02a81c7a347ffc4/ios/web/web_state/navigation_callbacks_inttest.mm [modify] https://crrev.com/733b148a005e70786525f314e02a81c7a347ffc4/ios/web/web_state/ui/crw_web_controller.mm
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f7ffae9f77a4392a4f35c05d75ec9a46bdaee9e commit 9f7ffae9f77a4392a4f35c05d75ec9a46bdaee9e Author: Yuke Liao <liaoyuke@chromium.org> Date: Fri Nov 17 18:39:34 2017 Revert "Fixed Navigation callbacks for failed provisional navigation." This reverts commit 02bddfd9587ac7bb74b5e4cc756b669dada3184c. Reason for revert: NavigationCallbacksTest.FailedNavigation is failing on devices, and only devices, both iPhones and iPads with iOS 10 and iOS 11. Original change's description: > Fixed Navigation callbacks for failed provisional navigation. > > Verified callbacks correctness with > NavigationCallbacksTest.FailedNavigation integration test. > > Before this CL DidStartNavigation was called twice (second time > for presenting error in Native Content). DidFinishNavigation was > called once (also for presenting NativeContent). First > DidStartNavigation did not have a matching DidStartNavigation > call. > > This CL removes DidStartNavigation/DidFinishNavigation callbacks > for for presenting error in Native Content and adds balanced > DidFinishNavigation callback in handleLoadingError:. > > Bug: 725241 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Id15ef8c9422e571f74f9c00bf88ea98ccbf6607c > Reviewed-on: https://chromium-review.googlesource.com/758718 > Commit-Queue: Eugene But <eugenebut@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517420} TBR=eugenebut@chromium.org,kkhorimoto@chromium.org Change-Id: I76bc2987780795fd72284b22203e945387f04c53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/777279 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517491}
,
Jan 30 2018
,
Apr 12 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92423d68aa24c7f7563a30d6478e86661a9f1671 commit 92423d68aa24c7f7563a30d6478e86661a9f1671 Author: Eugene But <eugenebut@google.com> Date: Tue Apr 17 22:09:19 2018 Renamed kDisplayingErrorForFailedNavigation enum value. The new name is kDisplayingNativeErrorForFailedNavigation. This change is needed to support HTML based error pages which will use kDisplayingWebErrorForFailedNavigation enum. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id68e8239d9706b8d98bc591a0d264609b13e23c0 Reviewed-on: https://chromium-review.googlesource.com/1015531 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#551493} [modify] https://crrev.com/92423d68aa24c7f7563a30d6478e86661a9f1671/ios/web/navigation/navigation_item_impl.h [modify] https://crrev.com/92423d68aa24c7f7563a30d6478e86661a9f1671/ios/web/navigation/navigation_item_impl.mm [modify] https://crrev.com/92423d68aa24c7f7563a30d6478e86661a9f1671/ios/web/navigation/navigation_item_impl_unittest.mm [modify] https://crrev.com/92423d68aa24c7f7563a30d6478e86661a9f1671/ios/web/web_state/ui/crw_web_controller.mm
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aebe39ad7263881657e0e163029e18b7e189c157 commit aebe39ad7263881657e0e163029e18b7e189c157 Author: Eugene But <eugenebut@google.com> Date: Mon Apr 23 18:06:35 2018 Add WebClient::PrepareErrorPage ios/web API. This API matches ContentRendererClient::PrepareErrorPage from //content and will be used to load errors into WKWebView as HTML. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I656f2c892430de2840196a224a446111b44f4d9c Reviewed-on: https://chromium-review.googlesource.com/1011383 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#552750} [modify] https://crrev.com/aebe39ad7263881657e0e163029e18b7e189c157/ios/web/BUILD.gn [modify] https://crrev.com/aebe39ad7263881657e0e163029e18b7e189c157/ios/web/public/web_client.h [modify] https://crrev.com/aebe39ad7263881657e0e163029e18b7e189c157/ios/web/web_client.mm [add] https://crrev.com/aebe39ad7263881657e0e163029e18b7e189c157/ios/web/web_client_unittest.mm
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74cfc94b64a13365eb1a4261f2c469e19b85342c commit 74cfc94b64a13365eb1a4261f2c469e19b85342c Author: Eugene But <eugenebut@google.com> Date: Tue Apr 24 15:28:32 2018 Add kDisplayingWebErrorForFailedNavigation constant. This adds value to web::ErrorRetryState enum, which will be used to display HTML error page in WKWebView if kWebErrorPages feature flag is enabled. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iefaa75626477dc0d810b85b8d7726325a0fe217b Reviewed-on: https://chromium-review.googlesource.com/1025011 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#553129} [modify] https://crrev.com/74cfc94b64a13365eb1a4261f2c469e19b85342c/ios/web/navigation/navigation_item_impl.h [modify] https://crrev.com/74cfc94b64a13365eb1a4261f2c469e19b85342c/ios/web/web_state/ui/crw_web_controller.mm
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e3549de2ac83ac2ce30461bc01cd3ed97350e4d commit 6e3549de2ac83ac2ce30461bc01cd3ed97350e4d Author: Eugene But <eugenebut@google.com> Date: Tue Apr 24 21:33:46 2018 Add feature flag for displaying HTML-based error pages in ios/web. The flag is not currently used and disabled. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idf29f755276aedd56d78522a24cda21703be2929 Reviewed-on: https://chromium-review.googlesource.com/1024925 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#553286} [modify] https://crrev.com/6e3549de2ac83ac2ce30461bc01cd3ed97350e4d/ios/web/features.mm [modify] https://crrev.com/6e3549de2ac83ac2ce30461bc01cd3ed97350e4d/ios/web/public/features.h
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f301071662188cfb9ccde873260a3b6f20467d6d commit f301071662188cfb9ccde873260a3b6f20467d6d Author: Eugene But <eugenebut@google.com> Date: Tue Apr 24 22:33:07 2018 Extract GetErrorPage function from ErrorPageGenerator class. GetErrorPage function will be used in ChromeWebClient::PrepareErrorPage. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id2f9f3e86d9685ad0ac448bc767f7daf4a80e3be Reviewed-on: https://chromium-review.googlesource.com/1024277 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#553325} [modify] https://crrev.com/f301071662188cfb9ccde873260a3b6f20467d6d/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/f301071662188cfb9ccde873260a3b6f20467d6d/ios/chrome/browser/web/error_page_generator.mm [add] https://crrev.com/f301071662188cfb9ccde873260a3b6f20467d6d/ios/chrome/browser/web/error_page_util.h [add] https://crrev.com/f301071662188cfb9ccde873260a3b6f20467d6d/ios/chrome/browser/web/error_page_util.mm [add] https://crrev.com/f301071662188cfb9ccde873260a3b6f20467d6d/ios/chrome/browser/web/error_page_util_unittest.mm
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e22eb6fbdc57eca9d62a9912eb1445f9fc2677a commit 2e22eb6fbdc57eca9d62a9912eb1445f9fc2677a Author: Eugene But <eugenebut@chromium.org> Date: Thu Apr 26 15:56:10 2018 Rename loadErrorInNativeViewForNavigationItem. Use more generic loadErrorPageForNavigationItem name, because future implementation of this method will not use NativeContent. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I23af2dd725e91e27600689ccdf0e536c6756068c Reviewed-on: https://chromium-review.googlesource.com/1029491 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#554041} [modify] https://crrev.com/2e22eb6fbdc57eca9d62a9912eb1445f9fc2677a/ios/web/web_state/ui/crw_web_controller.mm
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13a92cca09f3f0785489298011b6c87222e1c44c commit 13a92cca09f3f0785489298011b6c87222e1c44c Author: Eugene But <eugenebut@google.com> Date: Fri Apr 27 21:15:27 2018 Implement ChromeWebClient::PrepareErrorPage. The implementation simply calls GetErrorPage. This method returns HTML for web based error page rendered in WKWebView. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie68e8e052d06f8106a9209f21f811dc323a5ab5e Reviewed-on: https://chromium-review.googlesource.com/1033023 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554511} [modify] https://crrev.com/13a92cca09f3f0785489298011b6c87222e1c44c/ios/chrome/browser/web/BUILD.gn [modify] https://crrev.com/13a92cca09f3f0785489298011b6c87222e1c44c/ios/chrome/browser/web/chrome_web_client.h [modify] https://crrev.com/13a92cca09f3f0785489298011b6c87222e1c44c/ios/chrome/browser/web/chrome_web_client.mm [modify] https://crrev.com/13a92cca09f3f0785489298011b6c87222e1c44c/ios/chrome/browser/web/chrome_web_client_unittest.mm [modify] https://crrev.com/13a92cca09f3f0785489298011b6c87222e1c44c/ios/web/web_client.mm
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba52eee80745293f554e4420863e1f8ef81c82b4 commit ba52eee80745293f554e4420863e1f8ef81c82b4 Author: Eugene But <eugenebut@google.com> Date: Fri May 04 16:25:48 2018 Extend ErrorPageTestCase with back-forward and reload navigation tests. Added the following test cases: - testReloadPageAfterServerIsDown - testGoForwardAfterServerIsDownAndReload - testGoBackFromErrorPage Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a872e6691c66ff6facd100cdb90607488738ff6 Reviewed-on: https://chromium-review.googlesource.com/1043074 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#556082} [modify] https://crrev.com/ba52eee80745293f554e4420863e1f8ef81c82b4/ios/chrome/browser/web/error_page_egtest.mm
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85d94fd334e5df67195bbef8513b0df5bbb570b8 commit 85d94fd334e5df67195bbef8513b0df5bbb570b8 Author: Eugene But <eugenebut@google.com> Date: Fri May 04 22:20:32 2018 Add HandleEchoQueryOrCloseSocket for testing error pages. This handler will be used for EG and ios_web_inttests error pages tests. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibd7fc021c5ed5d2c76c63e465e988eb81b913037 Reviewed-on: https://chromium-review.googlesource.com/1045108 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#556219} [modify] https://crrev.com/85d94fd334e5df67195bbef8513b0df5bbb570b8/ios/chrome/browser/web/error_page_egtest.mm [modify] https://crrev.com/85d94fd334e5df67195bbef8513b0df5bbb570b8/ios/testing/embedded_test_server_handlers.cc [modify] https://crrev.com/85d94fd334e5df67195bbef8513b0df5bbb570b8/ios/testing/embedded_test_server_handlers.h
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4af1de2501c6392fd778dad5647096b15009d0c commit d4af1de2501c6392fd778dad5647096b15009d0c Author: Eugene But <eugenebut@google.com> Date: Tue May 08 01:37:01 2018 Load ErrorPages without NativeContent. This CL uses -[WKWebView loadHTML:forURL:] to present error pages. This approach matches //content and replaces deprecated NativeContent API. Design doc: https://docs.google.com/document/d/10Tp_Zj4CJ5PSiJATHVomKAxqaBKLxkfIkYR0ZD-P7EY/edit?usp=drive_web&ouid=106048695919657955766 Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1e1474784f8edbbaa63565193bafe30dbb658a12 Reviewed-on: https://chromium-review.googlesource.com/1043104 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556636} [modify] https://crrev.com/d4af1de2501c6392fd778dad5647096b15009d0c/ios/chrome/browser/web/error_page_egtest.mm [modify] https://crrev.com/d4af1de2501c6392fd778dad5647096b15009d0c/ios/web/navigation/navigation_item_impl.mm [modify] https://crrev.com/d4af1de2501c6392fd778dad5647096b15009d0c/ios/web/web_state/ui/crw_web_controller.mm
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94612d7940005f708eb1eb7bbd2841c75275554f commit 94612d7940005f708eb1eb7bbd2841c75275554f Author: Eugene But <eugenebut@google.com> Date: Tue May 08 19:17:00 2018 Ported ErrorPageTestCase to ios_web_inttest. This CL adds ErrorPageTest ios_web_inttest for error pages. These tests are faster than EG tests and can test is_post and is_off_the_record arguments passed to TestWebClient. ErrorPageTestCase exists, because it's not possible to test old implementation with ios_web_inttest infrastructure. ErrorPageTestCase will be removed when old error pages code is no longer supported. Tests for is_post and is_off_the_record arguments will be added in a separate CL. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic06e9613c6e69a488ac734922ffc691f124bd24b Reviewed-on: https://chromium-review.googlesource.com/1047951 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556915} [modify] https://crrev.com/94612d7940005f708eb1eb7bbd2841c75275554f/ios/chrome/browser/web/error_page_egtest.mm [modify] https://crrev.com/94612d7940005f708eb1eb7bbd2841c75275554f/ios/web/BUILD.gn [add] https://crrev.com/94612d7940005f708eb1eb7bbd2841c75275554f/ios/web/web_state/error_page_inttest.mm
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85b8f517734cf9995091e9017851d3803ec1686b commit 85b8f517734cf9995091e9017851d3803ec1686b Author: Eugene But <eugenebut@google.com> Date: Wed May 09 14:35:53 2018 Correctly pass |is_off_the_record| argument to PrepareErrorPage. Also added a test to verify the argument. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5655f92b64251a89b1bea9eb1e42b146ff4a7e73 Reviewed-on: https://chromium-review.googlesource.com/1050413 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#557176} [modify] https://crrev.com/85b8f517734cf9995091e9017851d3803ec1686b/ios/web/web_state/error_page_inttest.mm [modify] https://crrev.com/85b8f517734cf9995091e9017851d3803ec1686b/ios/web/web_state/ui/crw_web_controller.mm
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a23c8fbc2961c57d10282080df98b969e817a96e commit a23c8fbc2961c57d10282080df98b969e817a96e Author: Eugene But <eugenebut@google.com> Date: Mon May 14 20:40:23 2018 Add kWebErrorPages flag to chrome://flags. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I92403b3a703965fa90cdfe998421463a6a3fec59 Reviewed-on: https://chromium-review.googlesource.com/1054006 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#558448} [modify] https://crrev.com/a23c8fbc2961c57d10282080df98b969e817a96e/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/a23c8fbc2961c57d10282080df98b969e817a96e/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/a23c8fbc2961c57d10282080df98b969e817a96e/ios/chrome/browser/ios_chrome_flag_descriptions.h
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcc9338383c78cf9ebb2712f991a9e4414229a14 commit dcc9338383c78cf9ebb2712f991a9e4414229a14 Author: Eugene But <eugenebut@google.com> Date: Wed May 16 20:13:07 2018 Add ErrorPageTest.FormSubmissionError integration test. The test verifies is_post argument passed to WebClient::PrepareErrorPage Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9f5a6035f1c49dc3cc0a1a144b096ff2fc035989 Reviewed-on: https://chromium-review.googlesource.com/1062079 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#559254} [modify] https://crrev.com/dcc9338383c78cf9ebb2712f991a9e4414229a14/ios/web/web_state/error_page_inttest.mm
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee4ffbd6597f52e7fd3a7b0f2e4607f6e399c4cd commit ee4ffbd6597f52e7fd3a7b0f2e4607f6e399c4cd Author: Eugene But <eugenebut@google.com> Date: Tue Jun 05 20:42:30 2018 Do not call PolicyDecider callbacks for placeholder URLs. Placeholder URLs are also used for WebErrorPages features, so this CL ignores placeholder URLs in decidePolicy callbacks if WebErrorPages is enabled. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I54fb0a5e6dd692d741db4bac298f760165d276f7 Reviewed-on: https://chromium-review.googlesource.com/1087364 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#564652} [modify] https://crrev.com/ee4ffbd6597f52e7fd3a7b0f2e4607f6e399c4cd/ios/web/web_state/ui/crw_web_controller.mm
,
Jun 11 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a58540d65efa2ed11080dbf2a809f049d426a84e commit a58540d65efa2ed11080dbf2a809f049d426a84e Author: Eugene But <eugenebut@google.com> Date: Thu Jun 14 15:37:04 2018 Fix going forward to error page if kWebErrorPages is enabled. Added LoadingErrorPage flag to NavigationContext to mark LoadHTMLString: navigations which feed Error page to WKWebView. These navigations will be ignored in WKWebViewNavigationDelegate callbacks. GoBackFromErrorPage and testGoBackFromErrorPage tests were updated to cover this test case. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1a38685d96997328c4be2a250dcedb5837e76d77 Reviewed-on: https://chromium-review.googlesource.com/1093515 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#567281} [modify] https://crrev.com/a58540d65efa2ed11080dbf2a809f049d426a84e/ios/chrome/browser/web/error_page_egtest.mm [modify] https://crrev.com/a58540d65efa2ed11080dbf2a809f049d426a84e/ios/web/navigation/error_retry_state_machine.h [modify] https://crrev.com/a58540d65efa2ed11080dbf2a809f049d426a84e/ios/web/navigation/error_retry_state_machine.mm [modify] https://crrev.com/a58540d65efa2ed11080dbf2a809f049d426a84e/ios/web/navigation/error_retry_state_machine_unittest.mm [modify] https://crrev.com/a58540d65efa2ed11080dbf2a809f049d426a84e/ios/web/web_state/error_page_inttest.mm [modify] https://crrev.com/a58540d65efa2ed11080dbf2a809f049d426a84e/ios/web/web_state/navigation_context_impl.h [modify] https://crrev.com/a58540d65efa2ed11080dbf2a809f049d426a84e/ios/web/web_state/navigation_context_impl.mm [modify] https://crrev.com/a58540d65efa2ed11080dbf2a809f049d426a84e/ios/web/web_state/ui/crw_web_controller.mm
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a2072b3c504b0daa27e9764094bd8b061e93f96 commit 3a2072b3c504b0daa27e9764094bd8b061e93f96 Author: Eugene But <eugenebut@google.com> Date: Fri Jun 15 17:35:41 2018 Replace testHistoryForwardToErrorPage with ErrorPage tests. New ErrorPage tests use EmbeddedTestServer instead of relying on DNS resolution error. Also new tests work with enabled WebErrorPages flag. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iad495dac2c5e3111809cf460c151187089b20698 Reviewed-on: https://chromium-review.googlesource.com/1101930 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#567714} [modify] https://crrev.com/3a2072b3c504b0daa27e9764094bd8b061e93f96/ios/chrome/browser/web/error_page_egtest.mm [modify] https://crrev.com/3a2072b3c504b0daa27e9764094bd8b061e93f96/ios/chrome/browser/web/navigation_egtest.mm [modify] https://crrev.com/3a2072b3c504b0daa27e9764094bd8b061e93f96/ios/web/web_state/error_page_inttest.mm
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2477061ee20006170c8986fecb025b8d48a68a2e commit 2477061ee20006170c8986fecb025b8d48a68a2e Author: Eugene But <eugenebut@google.com> Date: Tue Jun 19 19:00:05 2018 Fix NavigationAndLoadCallbacksTest.FailedNavigation when WebErrorPages enabled. Notable changes: - DidFinishNavigation and DidStopLoading order expectations are swapped in tests. This is OK, because WebStateObserver API contract does not guarantee specific order. - NavigationContextImpl::GetDescription was updated to print is_loading_error_page_ flag. - Commit Pending Item if WebErrorPages is enabled and SlimNavigationManager is disabled. Failed navigations must always be committed. - Ignore decidePolicyForNavigationAction: callback if NavigationContext::IsLoadingErrorPage() returns true. This will suppress extra PolicyDecider callbacks. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9bb8fc76ecd51054cd85fb43fd86353035b631de Reviewed-on: https://chromium-review.googlesource.com/1105186 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#568548} [modify] https://crrev.com/2477061ee20006170c8986fecb025b8d48a68a2e/ios/web/web_state/navigation_and_load_callbacks_inttest.mm [modify] https://crrev.com/2477061ee20006170c8986fecb025b8d48a68a2e/ios/web/web_state/navigation_context_impl.mm [modify] https://crrev.com/2477061ee20006170c8986fecb025b8d48a68a2e/ios/web/web_state/ui/crw_web_controller.mm
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d29f7111e9dbeb57e64c36d30045c0aaeb1d7f4 commit 8d29f7111e9dbeb57e64c36d30045c0aaeb1d7f4 Author: Eugene But <eugenebut@google.com> Date: Tue Jun 19 22:10:05 2018 Fix LoadIfNecessaryTest.RestoredFromHistory with WebErrorPages enabled. Updated BuildNavigationItemImpl to call SetURL instead of assigning to ivar. This way ErrorRetryStateMachine::SetURL gets called as required. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I72ee391dabe18c60ea2c01c384fa3485b9bee1e9 Reviewed-on: https://chromium-review.googlesource.com/1106973 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#568615} [modify] https://crrev.com/8d29f7111e9dbeb57e64c36d30045c0aaeb1d7f4/ios/web/navigation/navigation_item_storage_builder.mm
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2e072f3ce7eab05c76e6d32b642a44f46eced8f commit d2e072f3ce7eab05c76e6d32b642a44f46eced8f Author: Eugene But <eugenebut@google.com> Date: Wed Jun 20 21:30:06 2018 Enabled WebErrorPages feature by default. No major issues were found during manual testing. Safe to ship in M69. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I753c20d6525547958140d6407e8bd71d4f8ef0f7 Reviewed-on: https://chromium-review.googlesource.com/1086111 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#569024} [modify] https://crrev.com/d2e072f3ce7eab05c76e6d32b642a44f46eced8f/ios/web/features.mm
,
Jul 10
,
Jul 10
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1aeb6b28f04667cf3691cc4ff3530db9757a1cc7 commit 1aeb6b28f04667cf3691cc4ff3530db9757a1cc7 Author: Eugene But <eugenebut@chromium.org> Date: Wed Oct 10 18:40:02 2018 Do not mention ErrorPageContent in ReadingListWebStateObserver. ios/web behavior has changed so, existing comment is not valid anymore. Updated the comment to reflect current behavior. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I93e637fe5b7ca6d81210da063cd75f6618a1ff4c Reviewed-on: https://chromium-review.googlesource.com/c/1270517 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#598420} [modify] https://crrev.com/1aeb6b28f04667cf3691cc4ff3530db9757a1cc7/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c46acd7a69daf104e0ba2e81cc079282217050e9 commit c46acd7a69daf104e0ba2e81cc079282217050e9 Author: Eugene But <eugenebut@google.com> Date: Thu Oct 18 20:52:21 2018 Hide SetDisplayingNativeError behind kWebErrorPages flag. SetDisplayingNativeError should not be used if kWebErrorPages is enabled. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8a8be55dc0312fe60e9a4d403ed5e1ad78cbbf32 Reviewed-on: https://chromium-review.googlesource.com/c/1288975 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#600896} [modify] https://crrev.com/c46acd7a69daf104e0ba2e81cc079282217050e9/ios/web/navigation/error_retry_state_machine.h [modify] https://crrev.com/c46acd7a69daf104e0ba2e81cc079282217050e9/ios/web/navigation/error_retry_state_machine.mm [modify] https://crrev.com/c46acd7a69daf104e0ba2e81cc079282217050e9/ios/web/navigation/error_retry_state_machine_unittest.mm [modify] https://crrev.com/c46acd7a69daf104e0ba2e81cc079282217050e9/ios/web/web_state/ui/crw_web_controller.mm
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bd13b06dfd2fe72965e80597a58294ba12f811b commit 2bd13b06dfd2fe72965e80597a58294ba12f811b Author: Eugene But <eugenebut@chromium.org> Date: Mon Oct 22 16:17:10 2018 Remove kWebErrorPages flag. Notable changes: - removed redundant tests from ErrorPageTestCase (error_page_inttest cover these cases) - removed ErrorPageGenerator class - removed ErrorPageContent class - removed code which shows alert for non-printable pages Bug: 725241 , 694662 , 840489 , 859910 Change-Id: I0cad718200a3682633c0babf9b57b45cff39a579 Reviewed-on: https://chromium-review.googlesource.com/c/1289995 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#601604} [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/prerender/preload_controller.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/ui/browser_view_controller_unittest.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/web/BUILD.gn [delete] https://crrev.com/4676d794a8801cd5ae31b745ee124431d174f688/ios/chrome/browser/web/error_page_content.h [delete] https://crrev.com/4676d794a8801cd5ae31b745ee124431d174f688/ios/chrome/browser/web/error_page_content.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/web/error_page_egtest.mm [delete] https://crrev.com/4676d794a8801cd5ae31b745ee124431d174f688/ios/chrome/browser/web/error_page_generator.h [delete] https://crrev.com/4676d794a8801cd5ae31b745ee124431d174f688/ios/chrome/browser/web/error_page_generator.mm [delete] https://crrev.com/4676d794a8801cd5ae31b745ee124431d174f688/ios/chrome/browser/web/error_page_generator_unittest.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/features.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/navigation/error_retry_state_machine.h [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/navigation/error_retry_state_machine.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/navigation/error_retry_state_machine_unittest.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/public/features.h [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/public/test/fakes/test_native_content_provider.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/public/web_state/ui/crw_native_content_provider.h [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/web_state/error_page_inttest.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/web_state/web_state_observer_inttest.mm
,
Oct 22
,
Oct 26
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, May 22 2017