Stop using CRWNativeContentProvider and CRWNativeContent |
||||||||
Issue descriptionios/web should not be responsible for handling UI code in the same way as content. NTP, Bookmarks and Error Pages will use alternative API in the new architecture.
,
May 23 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 23 2018
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/164b093e430968abe970d2ab3711dfa023b20a27 commit 164b093e430968abe970d2ab3711dfa023b20a27 Author: Eugene But <eugenebut@google.com> Date: Fri May 25 21:41:29 2018 Remove -[CRWNativeContent dismissKeyboard]. This optional method is not implemented by native content classes. Bug: 725239 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I70bb3e0e308762bd90c354769eccd1cc2616ed73 Reviewed-on: https://chromium-review.googlesource.com/1073676 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#562024} [modify] https://crrev.com/164b093e430968abe970d2ab3711dfa023b20a27/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/164b093e430968abe970d2ab3711dfa023b20a27/ios/web/public/web_state/ui/crw_native_content.h
,
Jun 13 2018
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd3bffc75041f47d403dae70832447c766bfd691 commit dd3bffc75041f47d403dae70832447c766bfd691 Author: Eugene But <eugenebut@google.com> Date: Wed Oct 17 17:44:00 2018 Small fixes for navigation callbacks. This CL fixes NavigationContext::IsRendererInitiated for reloads and WebStatePolicyDecider::RequestInfo::transition_type for browser-initiated navigation. Bug: 676129, 725239 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I608b208d204bc055fcfd6c34dd7bd2a04b9c232a Reviewed-on: https://chromium-review.googlesource.com/c/1282448 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#600460} [modify] https://crrev.com/dd3bffc75041f47d403dae70832447c766bfd691/ios/chrome/browser/ui/payments/payment_request_journey_logger_egtest.mm [modify] https://crrev.com/dd3bffc75041f47d403dae70832447c766bfd691/ios/web/web_state/ui/crw_web_controller.h [modify] https://crrev.com/dd3bffc75041f47d403dae70832447c766bfd691/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/dd3bffc75041f47d403dae70832447c766bfd691/ios/web/web_state/web_state_impl.mm [modify] https://crrev.com/dd3bffc75041f47d403dae70832447c766bfd691/ios/web/web_state/web_state_observer_inttest.mm [modify] https://crrev.com/dd3bffc75041f47d403dae70832447c766bfd691/ios/web_view/test/navigation_delegate_inttest.mm
,
Oct 26
,
Oct 26
,
Oct 26
,
Dec 10
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by eugene...@chromium.org
, May 22 2017