New issue
Advanced search Search tips

Issue 725237 link

Starred by 1 user
Status: Fixed
Owner:
zhangtiff@chromium.org
Closed: Jun 2017
Cc:
seanmccullough@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Load trees directly into Sheriff-o-Matic instead of using AJAX

Project Member Reported by zhangtiff@chromium.org, May 22 2017 
The trees themselves on Sheriff-o-Matic never really change or get reloaded, so I think it's not really that useful to have them retrieved using an AJAX request. 

We could remove the /api/v1/trees/ endpoint in favor of just directly passing in an JSON with all the trees into Sheriff-o-Matic's frontend. Then, users won't have to wait for the ajax requests to finish for the trees to load either.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8f7811c398a3bb345a823d9aa642a0164e2f2803

commit 8f7811c398a3bb345a823d9aa642a0164e2f2803
Author: Tiff Zhang <zhangtiff@google.com>
Date: Thu Jun 08 22:28:15 2017

SoM: Load trees directly into som-app instead of through AJAX.
Bug:725237

Change-Id: Ie7f7bb4df229ec07a905c0b104ce20d42f44778c
Reviewed-on: https://chromium-review.googlesource.com/528419
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/index.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.js
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.js
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-drawer-test.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/main.go
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/som/main_test.go
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/som/trees.go
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-app-test.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.js
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8f7811c398a3bb345a823d9aa642a0164e2f2803

commit 8f7811c398a3bb345a823d9aa642a0164e2f2803
Author: Tiff Zhang <zhangtiff@google.com>
Date: Thu Jun 08 22:28:15 2017

SoM: Load trees directly into som-app instead of through AJAX.
Bug:725237

Change-Id: Ie7f7bb4df229ec07a905c0b104ce20d42f44778c
Reviewed-on: https://chromium-review.googlesource.com/528419
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/index.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.js
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.js
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-drawer-test.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/main.go
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/som/main_test.go
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/som/trees.go
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-app-test.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.js
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8f7811c398a3bb345a823d9aa642a0164e2f2803

commit 8f7811c398a3bb345a823d9aa642a0164e2f2803
Author: Tiff Zhang <zhangtiff@google.com>
Date: Thu Jun 08 22:28:15 2017

SoM: Load trees directly into som-app instead of through AJAX.
Bug:725237

Change-Id: Ie7f7bb4df229ec07a905c0b104ce20d42f44778c
Reviewed-on: https://chromium-review.googlesource.com/528419
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/index.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.js
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.js
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-drawer-test.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/main.go
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/som/main_test.go
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/som/trees.go
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-app-test.html
[modify] https://crrev.com/8f7811c398a3bb345a823d9aa642a0164e2f2803/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.js

Comment 4 by zhangtiff@chromium.org, Jun 8 2017

Status: Fixed (was: Assigned)
Should be out with the next deployment. :)
►

Sign in to add a comment