libwebp causes link errors with arm_use_neon=false |
||
Issue descriptionChrome Version: all OS: android arm targets What steps will reproduce the problem? (1) gn gen --args='target_os="android" arm_use_neon=false' -C out (2) ninja -C out chrome_public_apk What is the expected result? Link completes successfully. What happens instead? ../../third_party/libwebp/dsp/alpha_processing.c:387: error: undefined reference to 'WebPInitAlphaProcessingNEON' ../../third_party/libwebp/dsp/dec.c:775: error: undefined reference to 'VP8DspInitNEON' ../../third_party/libwebp/dsp/enc.c:911: error: undefined reference to 'VP8EncDspInitNEON' ../../third_party/libwebp/dsp/filters.c:258: error: undefined reference to 'VP8FiltersInitNEON' ../../third_party/libwebp/dsp/lossless.c:645: error: undefined reference to 'VP8LDspInitNEON' ../../third_party/libwebp/dsp/lossless_enc.c:942: error: undefined reference to 'VP8LEncDspInitNEON' ../../third_party/libwebp/dsp/rescaler.c:224: error: undefined reference to 'WebPRescalerDspInitNEON' ../../third_party/libwebp/dsp/upsampling.c:248: error: undefined reference to 'WebPInitUpsamplersNEON'
,
May 22 2017
Originally noticed in: https://codereview.chromium.org/2879703002
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baf703ffaca53d257628f5244df99c86efbd576c commit baf703ffaca53d257628f5244df99c86efbd576c Author: James Zern <jzern@google.com> Date: Tue May 23 18:24:10 2017 libwebp: enable libwebp_dsp_neon for all arm targets fixes link errors for NEON init functions in certain configurations (android + arm + arm_use_neon=false). in cases where NEON is disabled stubs are produced, in the rest the NEON is compiled and in the android case support is detected at runtime. BUG= 725225 Change-Id: I3b5db31bdd8f5f0be7778efa7e6df0bdc98fd674 Reviewed-on: https://chromium-review.googlesource.com/511382 Reviewed-by: Paul Miller <paulmiller@chromium.org> Reviewed-by: Urvang Joshi <urvang@chromium.org> Commit-Queue: Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#473988} [modify] https://crrev.com/baf703ffaca53d257628f5244df99c86efbd576c/third_party/libwebp/BUILD.gn
,
May 24 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by schenney@chromium.org
, May 22 2017