New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 725208 link

Starred by 1 user
Status: Fixed
Owner:
█ jbau...@chromium.org
not on Chrome anymore
Closed: May 2017
Cc:
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

GPU.DirectComposition.CompositionMode shows lots of composed mode on some systems.

Project Member Reported by jbau...@chromium.org, May 22 2017 
It looks like many of these systems are Intel Cherry Trail (Cherryview)  (e.g. PCI ID 0x22b0, 0x22b1, 0x22b2). Based on GPU.DirectComposition.OverlaySupportFlags they support only direct overlays, not scaled, so I suspect this is happening when we're trying to use scaling with an overlay.
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54436b450d22d4ce66ea198ab9999c570c28f84e

commit 54436b450d22d4ce66ea198ab9999c570c28f84e
Author: jbauman <jbauman@chromium.org>
Date: Tue May 23 07:32:46 2017

Avoid scaling overlays on systems that don't support them.

Most systems that only support direct (unscaled) overlays are Intel
Cherry Trail. On these systems we want to make sure overlay swapchains
are the size they appear onscreen, so that no scaling is necessary.
Otherwise they may be displayed using compositing in DWM, which can be
much less efficient.

BUG= 725208 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2895783002
Cr-Commit-Position: refs/heads/master@{#473828}

[modify] https://crrev.com/54436b450d22d4ce66ea198ab9999c570c28f84e/gpu/ipc/service/direct_composition_surface_win.cc

Comment 2 by jbau...@chromium.org, May 25 2017

Status: Fixed (was: Started)
The issue was also happening on Valleyview/BayTrail. Looks like the patch reduced the overall composed percentage from 35% to 18%, which helps a lot.
►

Sign in to add a comment