WebView Renderer crash causes Browser crash (even when onRenderProcessGone implemented). |
||
Issue descriptionchromium: [FATAL:jni_android.cc(130)] Failed to find class org/chromium/components/crash/browser/CrashDumpManager I'm getting the above exception when running a WebView app which loads WebView, calls setWebViewClient with a client that implements onRenderProcessGone to return true, and then navigates to chrome://crash. native stack: logging::LogMessage::~LogMessage() base::android::GetClass(_JNIEnv*, char const*) base::android::LazyGetClass(_JNIEnv*, char const*, long*) base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base::MessageLoop::RunTask(base::PendingTask*) base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base::MessageLoop::Run() base::RunLoop::Run() base::Thread::Run(base::RunLoop*) base::Thread::ThreadMain() base::PlatformThread::SetCurrentThreadPriority(base::ThreadPriority) it is solved by including //components/crash/android:java in the deps files of //android_webview:android_webview_java but I don't understand why this happens in the first place, AFAICT we aren't using CrashDumpManager in WebView at all?
,
May 22 2017
Ah, yeah, there you go! I'll upload the fix in a sec.
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef6ff00396eb81157f1c7c4992a1bdcc8eba8113 commit ef6ff00396eb81157f1c7c4992a1bdcc8eba8113 Author: gsennton <gsennton@chromium.org> Date: Tue May 23 12:46:24 2017 [Android WebView] include CrashDumpManager java-side. The content/browser/crash/ component calls into the java-side of CrashDumpManager from components/crash/content/browser/crash_dump_manager_android.cc, since WebView doesn't include that java file it throws an exception at that point. This CL Includes the content/browser/crash/ component into Android WebView. BUG= 725207 Review-Url: https://codereview.chromium.org/2900793003 Cr-Commit-Position: refs/heads/master@{#473869} [modify] https://crrev.com/ef6ff00396eb81157f1c7c4992a1bdcc8eba8113/android_webview/BUILD.gn
,
May 23 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by isherman@chromium.org
, May 22 2017