New issue
Advanced search Search tips

Issue 725197 link

Starred by 2 users
Status: Assigned
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ExtensionUninstallDialogViewBrowserTest.EnsureCWSReportAbusePageIsActiveTabAfterUninstall flakily failing

Project Member Reported by mek@chromium.org, May 22 2017 
ExtensionUninstallDialogViewBrowserTest.EnsureCWSReportAbusePageIsActiveTabAfterUninstall recently is very flaky on Win 7 Tests x64:

https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29


[ RUN      ] ExtensionUninstallDialogViewBrowserTest.EnsureCWSReportAbusePageIsActiveTabAfterUninstall
c:\b\c\b\win\src\chrome\browser\ui\views\extensions\extension_uninstall_dialog_view_browsertest.cc(224): error:       Expected: 3
To be equal to: browser()->tab_strip_model()->count()
      Which is: 1
c:\b\c\b\win\src\chrome\browser\ui\views\extensions\extension_uninstall_dialog_view_browsertest.cc(233): error:       Expected: extension_urls::GetWebstoreReportAbuseUrl(extension->id(), kReferrerId)
      Which is: https://chrome.google.com/webstore/report/odlameecjipmbmbejkplpemijjgpljce?utm_source=chrome-remove-extension-dialog
To be equal to: GetActiveUrl(browser())
      Which is: "about:blank"

Comment 1 by mek@chromium.org, May 22 2017

Labels: -Sheriff-Chromium OS-Windows
Owner: catmulli...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91acb1336f85ded10cb6aa946f06dfadc4de6f0c

commit 91acb1336f85ded10cb6aa946f06dfadc4de6f0c
Author: mek <mek@chromium.org>
Date: Mon May 22 20:50:52 2017

Disable flaky ExtensionUninstallDialogViewBrowserTest.EnsureCWSReportAbusePageIsActiveTabAfterUninstall on windows

BUG=725197
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2898763003
Cr-Commit-Position: refs/heads/master@{#473685}

[modify] https://crrev.com/91acb1336f85ded10cb6aa946f06dfadc4de6f0c/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc

Comment 3 by mgiuca@chromium.org, May 25 2017 

 Issue 726259  has been merged into this issue.

Comment 4 by mgiuca@chromium.org, May 25 2017

Labels: OS-Linux Pri-1 Type-Bug-Regression
This is flaky in Linux as well.

List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllFeHRlbnNpb25Vbmluc3RhbGxEaWFsb2dWaWV3QnJvd3NlclRlc3QuRW5zdXJlQ1dTUmVwb3J0QWJ1c2VQYWdlSXNBY3RpdmVUYWJBZnRlclVuaW5zdGFsbAw.

Disabling fully. The other test added in the same CL was also disabled for being flaky. I've updated the TODO to point at this bug.

catmullings@: These tests were only added within the last week by r473401 so please have a look. Thanks.
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f53bac92726138a5a000349f146e490a2652469

commit 3f53bac92726138a5a000349f146e490a2652469
Author: Matt Giuca <mgiuca@chromium.org>
Date: Thu May 25 08:17:52 2017

Disable flaky test EnsureCWSReportAbusePageIsActiveTabAfterUninstall.

TBR=catmullings@chromium.org

Bug: 725197
Change-Id: I1a004c729fca79640473c8976ad3c2f42c8f40f6
Reviewed-on: https://chromium-review.googlesource.com/515003
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474604}
[modify] https://crrev.com/3f53bac92726138a5a000349f146e490a2652469/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc

Comment 6 by mgiuca@chromium.org, May 25 2017

Summary: ExtensionUninstallDialogViewBrowserTest.EnsureCWSReportAbusePageIsActiveTabAfterUninstall flakily failing (was: ExtensionUninstallDialogViewBrowserTest.EnsureCWSReportAbusePageIsActiveTabAfterUninstall flakily failing on Win 7 Tests x64)

Comment 7 by catmulli...@chromium.org, Feb 8 2018

Owner: ----
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04f1f3333adfdcc0bd2368727fd2b15d46417770

commit 04f1f3333adfdcc0bd2368727fd2b15d46417770
Author: Ryan Meier <rameier@chromium.org>
Date: Fri Nov 30 20:44:18 2018

Re-enable ExtensionUninstallDialogViewBrowserTest.EnsureCWSReportAbusePageIsActiveTabAfterUninstall

Bug: 725197
Change-Id: I24e0f3ff08ebd26f0621c2e16154f34a3dfd5467
Reviewed-on: https://chromium-review.googlesource.com/c/1355771
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612766}
[modify] https://crrev.com/04f1f3333adfdcc0bd2368727fd2b15d46417770/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc
►

Sign in to add a comment