New issue
Advanced search Search tips

Issue 725194 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Printer Name (Destination) field too short

Reported by tyler.l...@ccsd21.org, May 22 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce the problem:
1. Add printers to your computer, preferably from a print server using a long FQDN
2. Ctrl-P in Chrome to bring up the PrintPreview
3. Guess what printer is the current destination

What is the expected behavior?
Enough of the printer name is shown to see which printer is selected

What went wrong?
The field for Printer Name (Destination) is very short (only about 20 characters), and does not wrap. In some organizations, you can barely get through the print server's name before the actual printer's name is truncated. See attached for an example.

Did this work before? N/A 

Chrome version: 58.0.3029.110  Channel: stable
OS Version: 10.0
Flash Version: 

It'd be great to see this field hard-wrap if at all possible. The printer's Comment field shows up below, which is nice, but not always adequate.
 
badpreview.png
9.5 KB View Download
Labels: Needs-Triage-M58
Cc: jbanavatu@chromium.org
Components: UI>Browser>PrintPreview
Labels: -Needs-Triage-M58 M-60 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce on Windows 10,Ubuntu 14.04 and Mac OS 10.12 using chrome stable M58-58.0.3029.110 and latest M60-60.0.3108.0. Same behavior is seen from M35.
This seems to be a feature request . Hence,marking it as Untriaged to get more inputs from dev team.
Cc: hwi@chromium.org
Components: -UI
Labels: -Pri-2 -M-60 OS-Chrome Pri-3
I believe one can still see the full printer name by hovering over the printer name to see the tooltip.

hwi: Do you have suggestions on how we can improve this here? One suggestion is to have context aware eliding. e.g. For Windows printer shares in the form of \\server\printername, we can elide the server part if it's too long.
On Windows at least, Chrome does not refer to the printer by the same name as the System Dialog. This exacerbates the issue, and may actually be a more important problem to focus on...

Chrome displays the printer's full UNC path (example: "\\site-print-server.subdomain.domain.com\NicePrinterName").
Meanwhile, Windows system dialogs refer to the printer as "NicePrinterName on site-print-server.subdomain.domain.com".
The Windows approach is shared by nearly all other apps.

Comment 5 by hwi@chromium.org, Sep 6 2017

Showing printer name by default, and name with full path on hover seems a good direction. But please do share if that would break anything. Thanks!
That solution sounds pretty fantastic, actually.
Would it also apply to other printers on the system, as displayed in the Local Destinations list when clicking the Print Preview pane's Change button?

Thank you!

Comment 7 by hwi@chromium.org, Sep 7 2017

re: c6, 'Local Destinations list' - I think there's a benefit of showing full path by default in a spacious view. If there's also an issue on the list view, screenshots of an text overflow state will be helpful to understand. Thanks!
I think you're right about that. It's a good compromise.

My worry was about confusion between how Chrome could represent a printer's name differently in different areas. My old  Issue 347258  had a similar concern, where the Local Destinations List presented a different name than the current destination field, albeit with a much worse outcome.
It's possible there are other organizations that use very different names for printers than the UNC path would show.

But for the vast majority of users, having a readable/usable name in the short space for the current printer would be a solid improvement, and match the expectation they've built with other applications.
Status: Available (was: Untriaged)
Thanks for the suggestions and discussion. It sounds like we mainly want to change the UNC path, where the printer name is at the end, to Windows display-style network printer name, where the printer name is in front. We will do this consistently in different parts of the print preview UI, and not mix the two styles.

- In the destinations list, there is plenty of space, so we can display the full name.
- In the print dialog's left pane, where there is less space, we will display the elided name. e.g. "printer_name on site-pr..." and display the full name on hover.
Owner: thestig@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe379996e01a6eaf0b77ba42dafffd70478925b4

commit fe379996e01a6eaf0b77ba42dafffd70478925b4
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Sep 18 18:54:00 2017

Print Preview: Display friendly Windows network printer names.

\\server\printername becomes: printername on server. (localized)

BUG=725194

Change-Id: Ic56207831b6c65c495f6a277c4b3432cebd8b7b3
Reviewed-on: https://chromium-review.googlesource.com/669753
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502625}
[modify] https://crrev.com/fe379996e01a6eaf0b77ba42dafffd70478925b4/chrome/app/generated_resources.grd
[modify] https://crrev.com/fe379996e01a6eaf0b77ba42dafffd70478925b4/chrome/browser/ui/webui/print_preview/printer_capabilities.cc
[modify] https://crrev.com/fe379996e01a6eaf0b77ba42dafffd70478925b4/printing/backend/print_backend.h

Labels: Needs-Feedback
Tested this issue on the Windows 7, Mac OS 10.12.6 and Ubuntu 14.04 using the latest Canary 63.0.3218.0.

Could observe that on the print preview page, if the printer name is long, printer name is shown as printer-name abcxy..., and on hovering the mouse on the printer name, a tool tip is seen with the complete printer name.

Note: the same observation is seen on the reported version 58.0.3029.110 as well.

Please find the attached screen shots of the latest canary and reported version for reference.

thestig@- Could you please verify the screen shots and verify if this is the expected behavior?
Also let us know if anything missed from our side.

Thanks..

latest_canary.png
60.9 KB View Download
reported_version.png
71.7 KB View Download
Labels: -Needs-Feedback
r502625 only affects Windows network printers. It doesn't change the behavior for local printers with long names.
Cc: -hwi@chromium.org namratakannan@chromium.org
Owner: rbpotter@chromium.org

Sign in to add a comment