New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725187 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Huddly-updater build failure

Project Member Reported by porce@chromium.org, May 22 2017

Issue description

After landing https://chromium-review.googlesource.com/509269, the GoldenEye reported guado build failed while building sys-apps/huddly-updater package. 

huddly-updater-0.0.1-r21: LDCXX		huddly-updater
huddly-updater-0.0.1-r21: ../../../../../../usr/include/base-395517/base/logging.h:258: error: undefined reference to 'logging::BaseInitLoggingImpl_built_without_NDEBUG(logging::LoggingSettings const&)'
huddly-updater-0.0.1-r21: clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
huddly-updater-0.0.1-r21: make[1]: *** [common.mk:472: CXX_BINARY(huddly-updater)] Error 1
huddly-updater-0.0.1-r21: make[1]: Leaving directory '/build/guado/tmp/portage/sys-apps/huddly-updater-0.0.1-r21/work/huddly-updater-0.0.1'
huddly-updater-0.0.1-r21: make: *** [common.mk:171: _all] Error 2
huddly-updater-0.0.1-r21:  * ERROR: sys-apps/huddly-updater-0.0.1-r21::chromiumos failed (compile phase):
huddly-updater-0.0.1-r21:  *   emake failed
huddly-updater-0.0.1-r21:  * 

The error is not present when *locally* build at a developer's environment, when all the repo is synced, on master branches. This is independently confirmed from three engineer environments: porce@, sque@, frankhu@.

The error was not caught by commit-queue either, potentially due to the lack of the package's commit queue configuration.

 

Comment 1 by porce@chromium.org, May 22 2017

Cc: vapier@chromium.org
Labels: -Pri-3 Pri-1

Comment 2 by vapier@chromium.org, May 22 2017

Summary: Huddly-updater build failure (was: Huddly-updater build failure at GoldenEye)

Comment 3 by sque@chromium.org, May 22 2017

There's a discussion on the CL for this bug:
https://chromium-review.googlesource.com/c/510825/

Comment 4 by porce@chromium.org, May 22 2017

Description: Show this description

Comment 5 by porce@chromium.org, May 22 2017

Cc: choonc@google.com frankhu@chromium.org katierh@chromium.org jenchiehhuang@chromium.org
The commit queue configuration is https://chromium-review.googlesource.com/#/c/510784/ by bhthompson@.

Comment 6 Deleted

Comment 7 by porce@chromium.org, May 22 2017

Trybot with CL 510784 to guado-pre-cq came clean. 
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/pre_cq/builds/34372/steps/PreCQSync/logs/stdio

We suspect the stale state of the guado-release builder.
bhthompson initiated to clobber guado-release, and update the sheriff at go/crosoncall.

https://uberchromegw.corp.google.com/i/chromeos/builders/guado-release/builds/1148

Waiting for the build result.

Comment 8 by porce@chromium.org, May 23 2017

guado-release was clobbered, but came with the same build failure, while pre-cq are clean.

https://uberchromegw.corp.google.com/i/chromeos/builders/guado-release/builds/1148/steps/BuildPackages%20%5Bafdo_use%5D/logs/stdio

Comment 9 by porce@chromium.org, May 23 2017

A tentative solution is under prep by vapier@
https://chromium-review.googlesource.com/#/c/511004/

In parallel an immediate solution proposal (porce@ vapier@) is at 
https://chromium-review.googlesource.com/#/c/510825/

Comment 10 by porce@chromium.org, May 23 2017

No clue so far why there shows discrepancy between guado-pre-cq and guado-release.
Project Member

Comment 11 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1d76488bbc4fbc582c252fcb3a65f9fad1ccad9b

commit 1d76488bbc4fbc582c252fcb3a65f9fad1ccad9b
Author: Jiwoong Lee <porce@google.com>
Date: Tue May 23 01:19:24 2017

Add cros-workon_src_configure to huddly-updater ebuild

This is to fix the the build failure at guado-releas
since 9569.0.0 at GoldenEye.

See the bug for more detail.

BUG= chromium:725187 
TEST=Build huddly-updater package for Guado, and run on it.

Change-Id: Ia9aae7454edcf4bda70a10248141077023f42613
Reviewed-on: https://chromium-review.googlesource.com/510825
Tested-by: Jiwoong Lee <porce@chromium.org>
Trybot-Ready: Jiwoong Lee <porce@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Jiwoong Lee <porce@chromium.org>

[modify] https://crrev.com/1d76488bbc4fbc582c252fcb3a65f9fad1ccad9b/sys-apps/huddly-updater/huddly-updater-9999.ebuild

Project Member

Comment 12 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1d76488bbc4fbc582c252fcb3a65f9fad1ccad9b

commit 1d76488bbc4fbc582c252fcb3a65f9fad1ccad9b
Author: Jiwoong Lee <porce@google.com>
Date: Tue May 23 01:19:24 2017

Add cros-workon_src_configure to huddly-updater ebuild

This is to fix the the build failure at guado-releas
since 9569.0.0 at GoldenEye.

See the bug for more detail.

BUG= chromium:725187 
TEST=Build huddly-updater package for Guado, and run on it.

Change-Id: Ia9aae7454edcf4bda70a10248141077023f42613
Reviewed-on: https://chromium-review.googlesource.com/510825
Tested-by: Jiwoong Lee <porce@chromium.org>
Trybot-Ready: Jiwoong Lee <porce@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Jiwoong Lee <porce@chromium.org>

[modify] https://crrev.com/1d76488bbc4fbc582c252fcb3a65f9fad1ccad9b/sys-apps/huddly-updater/huddly-updater-9999.ebuild

Comment 13 by porce@chromium.org, May 23 2017

Labels: OS-Chrome
Status: Fixed (was: Untriaged)
CL 510825 resolved the issue; guado-release build came clean. (See go/goldeneye) for 2017-05-22 18:37 9578.0.0. This concludes the bug.


The investigation of this bug revealed in turn, another issue in ChromiumOS engineering process: a discrepancy in building between the release builder and {local dev, trybot, pre-commit queue}. 
 - while local build, trybot, pre-commit queue shows build success, the release builder showed build failure. 

This topic is related to the use of libchrome, NDEBUG compile time flag, and extra configuration in the per-package ebuild. 
I will  open a separate bug to track this down.


Labels: VerifyIn-61

Comment 15 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment