New issue
Advanced search Search tips

Issue 725186 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 725223
issue 728831
issue 728896

Blocking:
issue 727925



Sign in to add a comment

Add more capacity for tryserver.blink try bots

Project Member Reported by qyears...@chromium.org, May 22 2017

Issue description

I think that at this point it will be worth having two slaves for each try bot on tryserver.blink instead of one, in order to avoid long wait times when trying to rebaseline from try jobs.

This would include one more slave each for:

 win7_blink_rel
 win10_blink_rel
 mac10.9_blink_rel
 mac10.10_blink_rel
 mac10.11_blink_rel
 mac10.11_retina_blink_rel
 mac10.11_blink_rel

and probably linux_trusty_blink_rel too, even though it already has multiple slaves now since it's used for other things besides rebaselining already.

Current slaves.cfg:
https://cs.chromium.org/chromium/build/masters/master.tryserver.blink/slaves.cfg

Currently all slaves are "vm*-m4" slaves except for Retina (build115-b4) 

Dirk, does this sound alright? (Also, if so, should I file separate sub-bugs or CC anyone?)
 
yes, that sounds like a good idea. I'd probably just file one sub-bug for the labs folks to actually get the machines.
Components: -Infra>Labs>HWOps Blink>Infra
Labels: -Pri-3 Pri-2
Blockedon: 725223
Blocking: 727925
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/31c70fce76debbd8a71b385251d2f3a8f435e588

commit 31c70fce76debbd8a71b385251d2f3a8f435e588
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Jun 01 18:26:01 2017

Add new slaves to slaves.cfg on tryserver.blink.

Bug:  725186 
Change-Id: I4e96234d311b5f1bc529815da0a1baf523a36cb1
Reviewed-on: https://chromium-review.googlesource.com/518502
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Elliott Friedman <friedman@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/31c70fce76debbd8a71b385251d2f3a8f435e588/masters/master.tryserver.blink/slaves.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/31c70fce76debbd8a71b385251d2f3a8f435e588

commit 31c70fce76debbd8a71b385251d2f3a8f435e588
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Jun 01 18:26:01 2017

Add new slaves to slaves.cfg on tryserver.blink.

Bug:  725186 
Change-Id: I4e96234d311b5f1bc529815da0a1baf523a36cb1
Reviewed-on: https://chromium-review.googlesource.com/518502
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Elliott Friedman <friedman@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/31c70fce76debbd8a71b385251d2f3a8f435e588/masters/master.tryserver.blink/slaves.cfg

Owner: qyears...@chromium.org
Status: Started (was: Available)
Hm, it looks like in the original post I forgot to consider android_blink_rel -- but looking at the utilization stats for android_blink_rel, it seems that builder's capacity is fine -- over the past 7 days, it has only been in a state where all 3 slaves are busy a few times, and most of the time 0 or 1 slaves is used.

Note, before this issue is done, I think I need to request a master restart.
Blockedon: 728831
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/40e411904cd087d93a458c8d53a38aeff72f9fae

commit 40e411904cd087d93a458c8d53a38aeff72f9fae
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Jun 01 23:45:49 2017

Fix slaves.cfg - add back vm prefix for mac10.11_blink_rel

Accidentally used the wrong slave name in
https://chromium-review.googlesource.com/c/518502/

TBR_REASON=getting the builder back online
TBR=dpranke

Bug:  725186 
Change-Id: I0c365c02e8de6b9ffc0578e664fe446442bdfa56
Reviewed-on: https://chromium-review.googlesource.com/521735
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/40e411904cd087d93a458c8d53a38aeff72f9fae/masters/master.tryserver.blink/slaves.cfg

Blockedon: 728896
Status: Fixed (was: Started)
Alright, now each try bot builder has at least 2 slaves :-D

Sign in to add a comment