New issue
Advanced search Search tips

Issue 725182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Desktop web payments UI should include dependent locality, sorting code in shipping address labels.

Project Member Reported by rouslan@chromium.org, May 22 2017

Issue description

The desktop web payments UI omits sorting code and dependent locality when constructing labels for shipping addresses.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a338b49114af3a63152b690cbc9d4f22161650

commit 33a338b49114af3a63152b690cbc9d4f22161650
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Tue May 23 17:09:43 2017

Unify shipping address label creation for web payments UI.

Before this patch, the desktop web payments UI omitted sorting code and
dependent locality when constructing labels for shipping addresses. That
would confuse users located in such countries as France, where sorting
code is used.

This patch moves the iOS functions to create labels for shipping and
billing address labels into components/payments/core/strings_util.h and
uses these functions from both iOS and desktop. After this patch, the
shipping addresses on desktop show i18n addresses from all countries
correctly.

Bug:  725182 
Change-Id: I9d1fcc513d11914b54553644f82743d2685972c0
Reviewed-on: https://chromium-review.googlesource.com/511102
Reviewed-by: mahmadi <mahmadi@chromium.org>
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473951}
[modify] https://crrev.com/33a338b49114af3a63152b690cbc9d4f22161650/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/33a338b49114af3a63152b690cbc9d4f22161650/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/33a338b49114af3a63152b690cbc9d4f22161650/components/payments/core/strings_util.cc
[modify] https://crrev.com/33a338b49114af3a63152b690cbc9d4f22161650/components/payments/core/strings_util.h
[modify] https://crrev.com/33a338b49114af3a63152b690cbc9d4f22161650/ios/chrome/browser/payments/payment_request_util.mm

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment