Issue metadata
Sign in to add a comment
|
[MD Settings - buttons] No space between "import" and "import and bind buttons" |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 60.0.3105.0 (Official Build) dev (32-bit) Revision 0 Platform 9574.0.0 (Official Build) dev-channel elm What steps will reproduce the problem? 1. Open chrome://md-settings/certificates What happens ? There is no space between "IMPORT" and "IMPORT AND BIND" options Attached screenshot. Issue not seen on 9460.48.0, 59.0.3071.67
,
May 22 2017
,
May 22 2017
There is a similar problem with network buttons, I wonder if this is an artifact of removing 'secondary' buttons? +dschuyler@
,
May 22 2017
,
May 22 2017
,
May 25 2017
,
May 25 2017
,
May 26 2017
Issue 726644 has been merged into this issue.
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e959cddaeca101036a8edf445a5d57c629632afc commit e959cddaeca101036a8edf445a5d57c629632afc Author: dschuyler <dschuyler@chromium.org> Date: Wed May 31 22:31:27 2017 [MD settings] adjust button layout This CL gives proper spacing of paper-buttons in settings boxes. There are several cases to consider: a button at the start of a row; a button at the end of the row; multiple buttons in a row; buttons before or after a separator. BUG= 725172 , 726262 , 724944 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2902363002 Cr-Commit-Position: refs/heads/master@{#476067} [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/controls/controlled_button.html [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/ui/webui/resources/cr_elements/shared_style_css.html [modify] https://crrev.com/e959cddaeca101036a8edf445a5d57c629632afc/ui/webui/resources/cr_elements/shared_vars_css.html
,
May 31 2017
This should be merged into m60 once it's confirmed on canary.
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c366c9166c518e396d66db4edf2a7f0dba12e7f0 commit c366c9166c518e396d66db4edf2a7f0dba12e7f0 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Jun 07 21:03:17 2017 [MD settings] adjust button layout This CL gives proper spacing of paper-buttons in settings boxes. There are several cases to consider: a button at the start of a row; a button at the end of the row; multiple buttons in a row; buttons before or after a separator. BUG= 725172 , 726262 , 724944 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2902363002 Cr-Original-Commit-Position: refs/heads/master@{#476067} Review-Url: https://codereview.chromium.org/2931723002 . Cr-Commit-Position: refs/branch-heads/3112@{#235} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/controls/controlled_button.html [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/ui/webui/resources/cr_elements/shared_style_css.html [modify] https://crrev.com/c366c9166c518e396d66db4edf2a7f0dba12e7f0/ui/webui/resources/cr_elements/shared_vars_css.html
,
Jun 16 2017
9592.22.0, 60.0.3112.34 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dbeam@chromium.org
, May 22 2017