[Findit] Flake Analyzer - Pass analysis.key.urlsafe instead of explicit parameters in recursive_flake_pipeline.py |
||
Issue descriptionrecursive_flake_pipeline.py uses too many args/kwargs in the pipeline making updating the tests/adding confusing and cumbersome, especially when two different build numbers are needed - 1 for the triggering build number and the other for the build number to run the next swarming task on. master_name, builder_name, triggering_build_number, step_name, test_name are all built into the analysis' key, so pass the key and extract the mentioned parameters instead.
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a186e3c8baba2c3fb4e32116185563c7065edebc commit a186e3c8baba2c3fb4e32116185563c7065edebc Author: Jeffrey Li <lijeffrey@chromium.org> Date: Wed May 24 22:12:53 2017 [Findit] Flake Analyzer - pass analysis.key instead of explicit parameters Bug: 725163 Change-Id: I9f19e55507e105ecd2c1e27c27fb3e99dd183ab4 Reviewed-on: https://chromium-review.googlesource.com/510964 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [modify] https://crrev.com/a186e3c8baba2c3fb4e32116185563c7065edebc/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py [modify] https://crrev.com/a186e3c8baba2c3fb4e32116185563c7065edebc/appengine/findit/waterfall/flake/initialize_flake_pipeline.py [modify] https://crrev.com/a186e3c8baba2c3fb4e32116185563c7065edebc/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a186e3c8baba2c3fb4e32116185563c7065edebc commit a186e3c8baba2c3fb4e32116185563c7065edebc Author: Jeffrey Li <lijeffrey@chromium.org> Date: Wed May 24 22:12:53 2017 [Findit] Flake Analyzer - pass analysis.key instead of explicit parameters Bug: 725163 Change-Id: I9f19e55507e105ecd2c1e27c27fb3e99dd183ab4 Reviewed-on: https://chromium-review.googlesource.com/510964 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [modify] https://crrev.com/a186e3c8baba2c3fb4e32116185563c7065edebc/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py [modify] https://crrev.com/a186e3c8baba2c3fb4e32116185563c7065edebc/appengine/findit/waterfall/flake/initialize_flake_pipeline.py [modify] https://crrev.com/a186e3c8baba2c3fb4e32116185563c7065edebc/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
,
May 30 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 24 2017