New issue
Advanced search Search tips

Issue 725159 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Automation api hit test fails with non-integer coordinates

Project Member Reported by dmazz...@chromium.org, May 22 2017

Issue description

The automation API specifies the hit test coordinates should be integers which is fine since there's no reason for sub-pixel precision.

However, it crashes if you pass it a non-integer, which is not good! It should just round.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2dc689ce3df14d3fa613cc22c3f132c7eba4463

commit c2dc689ce3df14d3fa613cc22c3f132c7eba4463
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue May 23 17:36:17 2017

Automation API hit test should automatically convert to integer coordinates.

The automation API specifies the hit test coordinates should be
integers which is fine since there's no reason for sub-pixel
precision.

However, it crashes if you pass it a non-integer, which is not good!
It should just convert to an integer.

BUG= 725159 
TBR=aboxhall

Review-Url: https://codereview.chromium.org/2900803003
Cr-Commit-Position: refs/heads/master@{#473960}

[modify] https://crrev.com/c2dc689ce3df14d3fa613cc22c3f132c7eba4463/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/c2dc689ce3df14d3fa613cc22c3f132c7eba4463/chrome/test/data/extensions/api_test/automation/sites/hit_test.html
[modify] https://crrev.com/c2dc689ce3df14d3fa613cc22c3f132c7eba4463/chrome/test/data/extensions/api_test/automation/tests/desktop/hit_test.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment