Issue metadata
Sign in to add a comment
|
16167.6% regression in cc_perftests at 455819:473380 |
||||||||||||||||||||
Issue descriptionLooks like this "regressed" from a reasonable number of runs per second to millions of runs per second. Maybe the test is busted?
,
May 22 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8978872094883763744
,
May 23 2017
=== BISECT JOB RESULTS === Bisect failed for unknown reasons Please contact the team (see below) and report the error. Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : cc_perftests Metric : ParamTraits deserialization/num runs in 2 seconds_per_render_pass_shared_quad_state: DelegatedFrame_ManyRenderPasses_5_100 To Run This Test src/build/android/test_runner.py gtest --release -s cc_perftests --verbose Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8978872094883763744 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5491605437415424 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
May 23 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8978778532639710688
,
May 25 2017
=== BISECT JOB RESULTS === Bisect failed for unknown reasons Please contact the team (see below) and report the error. Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : cc_perftests Metric : ParamTraits deserialization/num runs in 2 seconds_per_render_pass_shared_quad_state: DelegatedFrame_ManyRenderPasses_5_100 To Run This Test src/build/android/test_runner.py gtest --release -s cc_perftests --verbose Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8978778532639710688 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5491605437415424 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jul 14 2017
,
Aug 21 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8970631694605794800
,
Aug 22 2017
=== BISECT JOB RESULTS === Bisect failed for unknown reasons Please contact the team (see below) and report the error. Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : cc_perftests Metric : ParamTraits deserialization/num runs in 2 seconds_per_render_pass_shared_quad_state: DelegatedFrame_ManyRenderPasses_5_100 To Run This Test src/build/android/test_runner.py gtest --release -s cc_perftests --verbose More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8970631694605794800 For feedback, file a bug with component Speed>Bisection
,
Aug 22 2017
The bisect keeps timing out after 24 hours, not sure what is going on here :( +Simon, any ideas?
,
Aug 22 2017
"bad_revision": "473380", "good_revision": "455818", This range is nearly 20k commits, and the recipe seems to be just trying to get commit info for each cl in the range. I can look into why it's doing that and if it's possible to defer anything.
,
Sep 21 2017
enne, weilangc: the bisect isn't going to work with such a large revision range. What should we do?
,
Sep 22 2017
For whatever reason, it looks like on android, that reading the CompositorFrameMetaData fails and so deserializing a compositor frame param traits early outs very quickly and so it's very fast. If I add a CHECK to the ReadMessage in CCSerializationPerfTest::RunDeserializationParamTraits, the test crashes for me. Also, I do see this test time out a ton, but I don't think this is cc_perftests running long. It feels more like a structural test runner issue.
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4558935100df073d5279e15d7a305e46c1e68c7 commit f4558935100df073d5279e15d7a305e46c1e68c7 Author: Adrienne Walker <enne@chromium.org> Date: Fri Sep 22 22:34:52 2017 Fix cc_perf_tests compositor frame deserialization Deserialization became very fast because deserializing was failing. The compositor frames don't successfully deserialize because they don't set the begin frame ack correctly. Fix this, and then CHECK that the deserialization succeeds. Bug: 725153 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iacd559fc91345bb3520af56426384f4c052ade7f Reviewed-on: https://chromium-review.googlesource.com/679695 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#503876} [modify] https://crrev.com/f4558935100df073d5279e15d7a305e46c1e68c7/cc/ipc/cc_serialization_perftest.cc
,
Sep 25 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by enne@google.com
, May 22 2017