New issue
Advanced search Search tips

Issue 725146 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 636090



Sign in to add a comment

Experiment with changing the min. number of requests in-flight when the throughput observation is taken

Project Member Reported by tbansal@chromium.org, May 22 2017 
Currently, Network Quality Estimator (NQE) takes an observation as long as there is at least one request in flight. In case of hanging GETs and TCP cold starts, this could sometimes cause NQE to take a lower throughput value.

We should experiment with changing the min. number of requests in-flight when the throughput observation is taken, and measure the effect on throughput prediction accuracy.
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff83205e7249a7b9c5a52c460162be7f14b295e8

commit ff83205e7249a7b9c5a52c460162be7f14b295e8
Author: tbansal <tbansal@chromium.org>
Date: Tue May 23 00:09:45 2017

Throughput: Change the min number of requests in flight required

In network quality estimator (NQE), change the minimum number of
requests in flight required before a throughput observation can be
taken. The parameter is controlled using field trial params, with
default value set to 1.

BUG= 725146 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2893933004
Cr-Commit-Position: refs/heads/master@{#473755}

[modify] https://crrev.com/ff83205e7249a7b9c5a52c460162be7f14b295e8/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/ff83205e7249a7b9c5a52c460162be7f14b295e8/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/ff83205e7249a7b9c5a52c460162be7f14b295e8/net/nqe/network_quality_estimator_params.h
[modify] https://crrev.com/ff83205e7249a7b9c5a52c460162be7f14b295e8/net/nqe/throughput_analyzer.cc
[modify] https://crrev.com/ff83205e7249a7b9c5a52c460162be7f14b295e8/net/nqe/throughput_analyzer.h
[modify] https://crrev.com/ff83205e7249a7b9c5a52c460162be7f14b295e8/net/nqe/throughput_analyzer_unittest.cc

Comment 2 by tbansal@chromium.org, Aug 31 2017

Labels: -Pri-3 M-62 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3a71ad7f80f95cb0e3cfd630133a4f3ba3dc736

commit e3a71ad7f80f95cb0e3cfd630133a4f3ba3dc736
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Sep 06 18:35:08 2017

Add Kbps estimate to UKM

Add downlink throughput estimate (in Kbps) obtained
from the Network Quality Estimator (NQE) to the
UKM reports.

Bug:  725146 
Change-Id: Id8acd185db5f3e746d408ce9b008377d7c338a8e
Reviewed-on: https://chromium-review.googlesource.com/648947
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500018}
[modify] https://crrev.com/e3a71ad7f80f95cb0e3cfd630133a4f3ba3dc736/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/e3a71ad7f80f95cb0e3cfd630133a4f3ba3dc736/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/e3a71ad7f80f95cb0e3cfd630133a4f3ba3dc736/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e3a71ad7f80f95cb0e3cfd630133a4f3ba3dc736/tools/metrics/ukm/ukm.xml

Comment 4 by bengr@chromium.org, Sep 14 2017

Labels: -Pri-2 Pri-3

Comment 5 by tbansal@chromium.org, Nov 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment