New issue
Advanced search Search tips

Issue 725111 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Collapse AppModalDialog into JavaScriptAppModalDialog

Project Member Reported by a...@chromium.org, May 22 2017

Issue description

AppModalDialog has only had that one subclass for years.
 

Comment 1 by a...@chromium.org, May 22 2017

https://codereview.chromium.org/63033 introduced AppModalDialog with:

"AppModalDialog is the model+controller, JavascriptMessageBoxDialog is the windows specific view."

https://codereview.chromium.org/560030 added the JavaScriptAppModalDialog and CookiePromptModalDialog subclasses.

The CookiePromptModalDialog subclass was removed in https://codereview.chromium.org/3299020 .
Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/373e72a7db96f15fa0adb679efb9992078500251

commit 373e72a7db96f15fa0adb679efb9992078500251
Author: avi <avi@chromium.org>
Date: Fri May 26 20:33:52 2017

Fold AppModalDialog into its only subclass, JavaScriptAppModalDialog.

There once was a second subclass, CookiePromptModalDialog, but it was removed in r59838, more than 6 years ago.

BUG= 725111 

Review-Url: https://codereview.chromium.org/2901583002
Cr-Commit-Position: refs/heads/master@{#475108}

[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/browser/extensions/alert_apitest.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/browser/extensions/lazy_background_page_apitest.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/browser/lifetime/browser_close_manager_browsertest.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/browser/unload_browsertest.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/chrome/test/base/ui_test_utils.h
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/components/app_modal/BUILD.gn
[delete] https://crrev.com/a11be0d57a4e4f214588bbd6fab9398824802b7f/components/app_modal/app_modal_dialog.cc
[delete] https://crrev.com/a11be0d57a4e4f214588bbd6fab9398824802b7f/components/app_modal/app_modal_dialog.h
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/components/app_modal/app_modal_dialog_queue.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/components/app_modal/app_modal_dialog_queue.h
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/components/app_modal/javascript_app_modal_dialog.cc
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/components/app_modal/javascript_app_modal_dialog.h
[modify] https://crrev.com/373e72a7db96f15fa0adb679efb9992078500251/components/app_modal/javascript_dialog_manager.cc

Comment 3 by a...@chromium.org, May 26 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment