New issue
Advanced search Search tips

Issue 725109 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:6269


Sign in to add a comment

Commit message change wipes Code-Review +2?

Project Member Reported by ljusten@chromium.org, May 22 2017

Issue description

E.g. in CL https://chromium-review.googlesource.com/c/508710:
Patch set 1 received Code-Review +2.
Patch set 2 only had commit message changes, Code-Review +2 was erased.

I believe I remember it not doing that.


 

Comment 1 by logan@google.com, May 22 2017

Cc: aga...@chromium.org
Components: -PolyGerrit
Labels: Proj-Gerrit-Migration
PS3 was a non-trivial rebase, and copyMaxScore is not enabled on the Code-Review label in either All-Projects or chromiumos.

I'm moving this over to the chrome-infra side with three suggestions to consider:

1. Modify Commit-Bot to revote on behalf of existing reviewers after landing the change. It already has logic in place to delete Commit-Queue votes on behalf of other users.

2. Set copyMaxScore = true to the Code-Review label section in a relevant project config. This means that unless explicitly revoked, approvals would pass on to subsequent patch sets no matter what is uploaded.

3. Get Gerrit to offer a more nuanced setting to carry votes forward in situations like this.

Comment 2 by logan@google.com, May 22 2017

Project: chromium
Moved issue gerrit:6269 to now be  issue chromium:725109 .

Comment 3 by aga...@chromium.org, May 22 2017

Components: Infra>Client>ChromeOS Infra>Codereview>Gerrit
Labels: -Proj=Gerrit-Migration
Owner: akes...@chromium.org
Status: Assigned (was: New)
This is a chromeos infra question; Chrome and related projects already carry the Code-Review label forward across new patchsets because that's how Rietveld behaved. ChromeOS does not carry the label forward for historical reasons. If they want to change that, they're welcome to, but it's not a policy decision for non-ChromeOS folks to make, I don't think.
Status: WontFix (was: Assigned)
Commit message changes can change actual behavior within build system, since CQ-DEPEND messages are parsed from them. Therefore, out of caution, updates to commit message are considered to require the same level of approval (committer access) to run through the the pre-cq/cq/etc.

Sign in to add a comment