Issue metadata
Sign in to add a comment
|
Commit message change wipes Code-Review +2? |
||||||||||||||||||||||
Issue descriptionE.g. in CL https://chromium-review.googlesource.com/c/508710: Patch set 1 received Code-Review +2. Patch set 2 only had commit message changes, Code-Review +2 was erased. I believe I remember it not doing that.
,
May 22 2017
,
May 22 2017
This is a chromeos infra question; Chrome and related projects already carry the Code-Review label forward across new patchsets because that's how Rietveld behaved. ChromeOS does not carry the label forward for historical reasons. If they want to change that, they're welcome to, but it's not a policy decision for non-ChromeOS folks to make, I don't think.
,
May 22 2017
Commit message changes can change actual behavior within build system, since CQ-DEPEND messages are parsed from them. Therefore, out of caution, updates to commit message are considered to require the same level of approval (committer access) to run through the the pre-cq/cq/etc. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by logan@google.com
, May 22 2017Components: -PolyGerrit
Labels: Proj-Gerrit-Migration