New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725105 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Feature



Sign in to add a comment

Add flag to enable Mojo GIN bindings in Chrome

Project Member Reported by reillyg@chromium.org, May 22 2017

Issue description

The Mojo GIN bindings are currently only available in content_shell when run with the --run-layout-test flag. This issue tracks the work to enable them in production builds of Chrome when run with a similar flag. This is to enable running Web Platform Tests that override Mojo services outside of the Chromium waterfall.
 
Cc: roc...@chromium.org
I've gotten sign-off to do this from rockot@. The other step necessary to run these tests outside of a Chromium build is to export the generated Mojo JS bindings into a Chromium-specific directory within the Web Platform Tests repository as these are not normally shipped with Chrome.

Comment 2 by roc...@chromium.org, May 22 2017

Oops, I forgot this bug existed. Please don't do this.

We're transitioning to the new native Blink Mojo bindings very soon, and
you can already turn those on with --enable-blink-features=MojoJS

Comment 3 by roc...@chromium.org, May 22 2017

In fact you can already generate bindings which use the new JS API by
setting use_new_js_bindings to true in your mojom GN rule.

From there you can simply script src
${out}/gen/mojo/public/js/mojo_bindings.js and whatever generated mojom js
you need.
Status: WontFix (was: Available)
Thanks! I'll give it a try.

Comment 5 by roc...@chromium.org, May 22 2017

Note, we'll still need to land an alternative for getting at a connector,
but I have a CL in progress for that which will also be available behind a
simple blink RuntimeEnabled flag.
Do you have an issue number for that or can you link to the CL here?

Comment 7 by roc...@chromium.org, May 22 2017

I guess we've been lumping things into 699569 and 723923 as precursors for
this use case. No bug exists specifically for the new connector API. I can
file one.
I came here from https://lists.w3.org/Archives/Public/public-test-infra/2017AprJun/0057.html

Was this not fixed with --enable-blink-features=MojoJS,MojoJSTest, or is that something else?
This is obsolete. We don't use gin bindings anymore, and yes the MojoJs feature flag addresses the spirit of the bug anyway.

Sign in to add a comment